[runtime] Do not use the enum-cache for non-prototype objects.

[runtime] Do not use the enum-cache for keys retrieval.

Currently we fail to properly handle shadowed properties. If the
receiver defines a non-enumerable property that reappears on the
prototype as enumerable it incorrectly shows up in [[Enumerate]].
By extending the KeyAccumulator to track non-enumerable properties
we can now properly filter them out when seeing them further up in
the prototype-chain.

BUG=v8:705
LOG=y

Committed: https://crrev.com/ed24dfe80d1da0827b8571839ee52c03ad09c9c7
Cr-Commit-Position: refs/heads/master@{#33405}

[Camillo Bruni, 2016-01-19 13:10:51]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-19 13:10:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608523002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608523002/80001

[commit-bot: I haz the power, 2016-01-19 13:13:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-19 13:13:59]

Dry run: Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/14262)

[Camillo Bruni, 2016-01-19 13:14:28]

Description was changed from

==========
[runtime] Do not use the enum-cache for non-prototype objects.

BUG=
==========

to

==========
[runtime] Do not use the enum-cache for keys retrieval.

Currently we fail to properly handle shadowed properties. If the 
receiver defines a non-enumerable property that reappears on the 
prototype as enumerable it incorrectly shows up in [[Enumerate]].
By extending the KeyAccumulator to track non-enumerable properties
we can now properly filter them out when seeing them further up in
the prototype-chain.


BUG=v8:705
LOG=y
==========

[Camillo Bruni, 2016-01-19 13:43:28]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-19 13:43:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608523002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608523002/100001

[commit-bot: I haz the power, 2016-01-19 13:48:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-19 13:48:11]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compil...)

[Camillo Bruni, 2016-01-19 14:14:07]

cbruni@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Camillo Bruni, 2016-01-19 14:14:07]

PTAL

[Jakob Kummerow, 2016-01-19 15:32:53]

Looks good, a few nits, waiting for next patch set as discussed.

https://codereview.chromium.org/1608523002/diff/120001/src/key-accumulator.h
File src/key-accumulator.h (right):

https://codereview.chromium.org/1608523002/diff/120001/src/key-accumulator.h#...
src/key-accumulator.h:8: #include <algorithm>
nit: I guess this can be moved to the .cc file?

https://codereview.chromium.org/1608523002/diff/120001/test/mjsunit/regress/r...
File test/mjsunit/regress/regress-705-shadowed_properties.js (right):

https://codereview.chromium.org/1608523002/diff/120001/test/mjsunit/regress/r...
test/mjsunit/regress/regress-705-shadowed_properties.js:1: // Copyright 2015 the
V8 project authors. All rights reserved.
nit: 2015 is so last year

https://codereview.chromium.org/1608523002/diff/120001/test/mjsunit/regress/r...
test/mjsunit/regress/regress-705-shadowed_properties.js:20: // Adding a
non-enumerable property to either a or b should change
nit: s/should/shouldn't/

https://codereview.chromium.org/1608523002/diff/120001/test/mjsunit/regress/r...
test/mjsunit/regress/regress-705-shadowed_properties.js:40:
Object.defineProperty(a, 'a3', propertyDescriptor);
You've already done this in line 29.

[Camillo Bruni, 2016-01-19 16:10:58]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-19 16:11:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608523002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608523002/160001

[commit-bot: I haz the power, 2016-01-19 16:16:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-19 16:16:26]

Dry run: Try jobs failed on following builders:
  v8_win_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/1633)

[Camillo Bruni, 2016-01-19 16:56:57]

PTAL again, reduced some more code and hopefully mostly restored the old
behavior of the enum-cache.

[Jakob Kummerow, 2016-01-20 10:38:51]

lgtm

[Camillo Bruni, 2016-01-20 11:57:23]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2016-01-20 11:57:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608523002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608523002/180001

[commit-bot: I haz the power, 2016-01-20 12:36:53]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-01-20 12:37:22]

Description was changed from

==========
[runtime] Do not use the enum-cache for keys retrieval.

Currently we fail to properly handle shadowed properties. If the 
receiver defines a non-enumerable property that reappears on the 
prototype as enumerable it incorrectly shows up in [[Enumerate]].
By extending the KeyAccumulator to track non-enumerable properties
we can now properly filter them out when seeing them further up in
the prototype-chain.


BUG=v8:705
LOG=y
==========

to

==========
[runtime] Do not use the enum-cache for keys retrieval.

Currently we fail to properly handle shadowed properties. If the
receiver defines a non-enumerable property that reappears on the
prototype as enumerable it incorrectly shows up in [[Enumerate]].
By extending the KeyAccumulator to track non-enumerable properties
we can now properly filter them out when seeing them further up in
the prototype-chain.

BUG=v8:705
LOG=y

Committed: https://crrev.com/ed24dfe80d1da0827b8571839ee52c03ad09c9c7
Cr-Commit-Position: refs/heads/master@{#33405}
==========

[commit-bot: I haz the power, 2016-01-20 12:37:22]

Patchset 10 (id:??) landed as
https://crrev.com/ed24dfe80d1da0827b8571839ee52c03ad09c9c7
Cr-Commit-Position: refs/heads/master@{#33405}

[Benedikt Meurer, 2016-01-21 05:27:25]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-01-21 05:27:26]

Sunspider string-fasta is not happy at all, 850% slower.

[Camillo Bruni, 2016-01-21 17:22:55]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.chromium.org/1619803003/ by cbruni@chromium.org.

The reason for reverting is: tanks for-in significantly.