src/messages.cc - Issue 1608523002: [runtime] Do not use the enum-cache for non-prototype objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.cc

Issue 1608523002: [runtime] Do not use the enum-cache for non-prototype objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: signed unsigned missmatch Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/messages.cc

diff --git a/src/messages.cc b/src/messages.cc

index 0365ec88021e0149bb894e565bbf17f6d4fdd3d9..ab1a3e793cbae167caaba38468ea7d8373866431 100644

--- a/src/messages.cc

+++ b/src/messages.cc

@@ -250,7 +250,8 @@ Handle<Object> CallSite::GetMethodName() {

if (!current->IsJSObject()) break;

Handle<JSObject> current_obj = Handle<JSObject>::cast(current);

if (current_obj->IsAccessCheckNeeded()) break;

- Handle<FixedArray> keys = JSObject::GetEnumPropertyKeys(current_obj, false);

+ Handle<FixedArray> keys =

+ JSObject::GetOwnEnumPropertyKeys(current_obj, false);

for (int i = 0; i < keys->length(); i++) {

HandleScope inner_scope(isolate_);

if (!keys->get(i)->IsName()) continue;

« no previous file with comments | « src/key-accumulator.cc ('k') | src/objects.h » ('j') | no next file with comments »