Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: src/elements.cc

Issue 1608523002: [runtime] Do not use the enum-cache for non-prototype objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: signed unsigned missmatch Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/key-accumulator.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/elements.h" 5 #include "src/elements.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/conversions.h" 8 #include "src/conversions.h"
9 #include "src/factory.h" 9 #include "src/factory.h"
10 #include "src/messages.h" 10 #include "src/messages.h"
(...skipping 1135 matching lines...) Expand 10 before | Expand all | Expand 10 after
1146 uint32_t index = static_cast<uint32_t>(k->Number()); 1146 uint32_t index = static_cast<uint32_t>(k->Number());
1147 if (index < offset) continue; 1147 if (index < offset) continue;
1148 PropertyDetails details = dictionary->DetailsAt(i); 1148 PropertyDetails details = dictionary->DetailsAt(i);
1149 if (filter & ONLY_ALL_CAN_READ) { 1149 if (filter & ONLY_ALL_CAN_READ) {
1150 if (details.kind() != kAccessor) continue; 1150 if (details.kind() != kAccessor) continue;
1151 Object* accessors = dictionary->ValueAt(i); 1151 Object* accessors = dictionary->ValueAt(i);
1152 if (!accessors->IsAccessorInfo()) continue; 1152 if (!accessors->IsAccessorInfo()) continue;
1153 if (!AccessorInfo::cast(accessors)->all_can_read()) continue; 1153 if (!AccessorInfo::cast(accessors)->all_can_read()) continue;
1154 } 1154 }
1155 PropertyAttributes attr = details.attributes(); 1155 PropertyAttributes attr = details.attributes();
1156 if ((attr & filter) != 0) continue; 1156 if ((attr & filter) != 0) {
1157 if (attr & PropertyAttributes::DONT_ENUM) {
1158 keys->HideKey(index);
1159 }
1160 continue;
1161 }
1157 keys->AddKey(index); 1162 keys->AddKey(index);
1158 } 1163 }
1159 1164
1160 keys->SortCurrentElementsList(); 1165 keys->SortCurrentElementsList();
1161 } 1166 }
1162 }; 1167 };
1163 1168
1164 1169
1165 // Super class for all fast element arrays. 1170 // Super class for all fast element arrays.
1166 template<typename FastElementsAccessorSubclass, 1171 template<typename FastElementsAccessorSubclass,
(...skipping 1248 matching lines...) Expand 10 before | Expand all | Expand 10 after
2415 } 2420 }
2416 } 2421 }
2417 2422
2418 DCHECK(j == result_len); 2423 DCHECK(j == result_len);
2419 return result_array; 2424 return result_array;
2420 } 2425 }
2421 2426
2422 ElementsAccessor** ElementsAccessor::elements_accessors_ = NULL; 2427 ElementsAccessor** ElementsAccessor::elements_accessors_ = NULL;
2423 } // namespace internal 2428 } // namespace internal
2424 } // namespace v8 2429 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/key-accumulator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698