[CSS] -webkit-var must be case sensitive according to specs

[CSS] -webkit-var must be case sensitive according to specs

The specs for CSS variables state that the prefix var- must be
case sensitive.

Add a check for this in fast/css/variables/case-sensitive.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151462

[alancutter (OOO until 2018), 2013-05-29 13:19:44]

https://codereview.chromium.org/16081003/diff/1/Source/core/css/CSSParser.cpp
File Source/core/css/CSSParser.cpp (right):

https://codereview.chromium.org/16081003/diff/1/Source/core/css/CSSParser.cpp...
Source/core/css/CSSParser.cpp:9345: {
I would add an ASSERT(*constantString) here lest this go flying off the deep end
should string = constantString = "".

[eseidel, 2013-05-29 23:10:25]

lgtm to unblock you.  Please get an lgtm from alan as well before landing.

[csaavedra, 2013-05-29 23:29:19]

On 2013/05/29 13:19:44, alancutter wrote:
> https://codereview.chromium.org/16081003/diff/1/Source/core/css/CSSParser.cpp
> File Source/core/css/CSSParser.cpp (right):
> 
>
https://codereview.chromium.org/16081003/diff/1/Source/core/css/CSSParser.cpp...
> Source/core/css/CSSParser.cpp:9345: {
> I would add an ASSERT(*constantString) here lest this go flying off the deep
end
> should string = constantString = "".

Done!

[alancutter (OOO until 2018), 2013-05-29 23:51:03]

On 2013/05/29 23:29:19, csaavedra wrote:
> On 2013/05/29 13:19:44, alancutter wrote:
> >
https://codereview.chromium.org/16081003/diff/1/Source/core/css/CSSParser.cpp
> > File Source/core/css/CSSParser.cpp (right):
> > 
> >
>
https://codereview.chromium.org/16081003/diff/1/Source/core/css/CSSParser.cpp...
> > Source/core/css/CSSParser.cpp:9345: {
> > I would add an ASSERT(*constantString) here lest this go flying off the deep
> end
> > should string = constantString = "".
> 
> Done!

lgtm

[commit-bot: I haz the power, 2013-05-30 00:03:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csaavedra@igalia.com/16081003/5001

[commit-bot: I haz the power, 2013-05-30 01:38:35]

Retried try job too often on mac_layout_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...

[commit-bot: I haz the power, 2013-05-30 06:58:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csaavedra@igalia.com/16081003/5001

[Mike Lawther (Google), 2013-05-30 09:31:49]

Too late now, but I feel a better change description would have been something
like "-webkit-var must be lower case", as that is what the spec actually says.

[commit-bot: I haz the power, 2013-05-30 11:28:23]

Change committed as 151462

[csaavedra, 2013-06-19 07:27:09]

On 2013/05/30 11:28:23, I haz the power (commit-bot) wrote:
> Change committed as 151462

Ignore the latest patch set, wrong branch.