[CSS] -webkit-var must be case sensitive according to specs

Source/core/css/CSSParser.cpp

 /*
  * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
  * Copyright (C) 2012 Intel Corporation. All rights reserved.
  *
@@ skipping 9323 matching lines @@
         // contains '-'. Otherwise toASCIILowerUnchecked('\r') would be equal to '-'.
         ASSERT((*constantString >= 'a' && *constantString <= 'z') || *constantString == '-');
         ASSERT(*constantString != '-' || isCSSLetter(*cssString));
         if (toASCIILowerUnchecked(*cssString++) != (*constantString++))
             return false;
     } while (*constantString);
     return true;
 }
 
 template <typename CharacterType>
+static inline bool isEqualToCSSCaseSensitiveIdentifier(CharacterType* string, const char* constantString)
+{

[alancutter (OOO until 2018), 2013/05/29 13:19:44]

I would add an ASSERT(*constantString) here lest this go flying off the deep end
should string = constantString = "".

+    do {
+        if (*string++ != *constantString++)
+            return false;
+    } while (*constantString);
+    return true;
+}
+
+template <typename CharacterType>
 static CharacterType* checkAndSkipEscape(CharacterType* currentCharacter)
 {
     // Returns with 0, if escape check is failed. Otherwise
     // it returns with the following character.
     ASSERT(*currentCharacter == '\\');
 
     ++currentCharacter;
     if (!isCSSEscape(*currentCharacter))
         return 0;
 
@@ skipping 897 matching lines @@
     }
 }
 
 template <typename CharacterType>
 inline bool CSSParser::detectCSSVariablesToken(int length)
 {
     ASSERT(tokenStart<CharacterType>()[0] == '-');
     if (length < sizeof("-webkit-var-*") - 1)
         return false;
     CharacterType* name = tokenStart<CharacterType>();
-    return name[11] == '-' && isIdentifierStartAfterDash(name + 12) && isEqualToCSSIdentifier(name + 1, "webkit-var");
+    return name[11] == '-' && isIdentifierStartAfterDash(name + 12) && isEqualToCSSCaseSensitiveIdentifier(name + 1, "webkit-var");
 }
 
 
 template <typename SrcCharacterType>
 int CSSParser::realLex(void* yylvalWithoutType)
 {
     YYSTYPE* yylval = static_cast<YYSTYPE*>(yylvalWithoutType);
     // Write pointer for the next character.
     SrcCharacterType* result;
     CSSParserString resultString;
@@ skipping 1470 matching lines @@
 {
     // The tokenizer checks for the construct of an+b.
     // However, since the {ident} rule precedes the {nth} rule, some of those
     // tokens are identified as string literal. Furthermore we need to accept
     // "odd" and "even" which does not match to an+b.
     return equalIgnoringCase(token, "odd") || equalIgnoringCase(token, "even")
         || equalIgnoringCase(token, "n") || equalIgnoringCase(token, "-n");
 }
 
 }