Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Unified Diff: Source/core/rendering/RenderView.cpp

Issue 16081003: [CSS] -webkit-var must be case sensitive according to specs (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use foreground color to render overtype caret Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderView.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderView.cpp
diff --git a/Source/core/rendering/RenderView.cpp b/Source/core/rendering/RenderView.cpp
index 32d63a0bcfa7130e5b007de7b28550cd4e6f33e5..3063c95ac5e2cc3d290d3f8b2ed9a24d9283a08b 100644
--- a/Source/core/rendering/RenderView.cpp
+++ b/Source/core/rendering/RenderView.cpp
@@ -23,6 +23,7 @@
#include "core/dom/Document.h"
#include "core/dom/Element.h"
+#include "core/editing/FrameSelection.h"
#include "core/html/HTMLFrameOwnerElement.h"
#include "core/html/HTMLIFrameElement.h"
#include "core/page/Frame.h"
@@ -60,6 +61,7 @@ RenderView::RenderView(Document* document)
, m_firstLazyBlock(0)
, m_renderQuoteHead(0)
, m_renderCounterCount(0)
+ , m_selectionWasCaret(false)
{
// init RenderObject attributes
setInline(false);
@@ -670,9 +672,11 @@ void RenderView::setSelection(RenderObject* start, int startPos, RenderObject* e
if ((start && !end) || (end && !start))
return;
+ bool caretChanged = m_selectionWasCaret != view()->frame()->selection()->isCaret();
+ m_selectionWasCaret = view()->frame()->selection()->isCaret();
// Just return if the selection hasn't changed.
if (m_selectionStart == start && m_selectionStartPos == startPos &&
- m_selectionEnd == end && m_selectionEndPos == endPos)
+ m_selectionEnd == end && m_selectionEndPos == endPos && !caretChanged)
return;
if ((start && end) && (start->flowThreadContainingBlock() != end->flowThreadContainingBlock()))
« no previous file with comments | « Source/core/rendering/RenderView.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698