Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1607473010: Match definition and declaration order of CookieMonster methods. (Closed)

Created:
4 years, 11 months ago by mmenke
Modified:
4 years, 11 months ago
Reviewers:
Mike West
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Match definition and declaration order of CookieMonster methods. BUG=none Committed: https://crrev.com/74bcbd548897b81ad7867001e634d6025d2d073f Cr-Commit-Position: refs/heads/master@{#370720}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -269 lines) Patch
M net/cookies/cookie_monster.h View 3 chunks +14 lines, -20 lines 2 comments Download
M net/cookies/cookie_monster.cc View 21 chunks +240 lines, -249 lines 1 comment Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
mmenke
Not sure if I should be sending these to you or Randy - may split ...
4 years, 11 months ago (2016-01-20 22:14:03 UTC) #2
Mike West
Copy/paste LGTM. If you'd like to run `git cl format` on the code and upload ...
4 years, 11 months ago (2016-01-21 09:28:36 UTC) #3
mmenke
On 2016/01/21 09:28:36, Mike West wrote: > Copy/paste LGTM. If you'd like to run `git ...
4 years, 11 months ago (2016-01-21 16:28:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1607473010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1607473010/1
4 years, 11 months ago (2016-01-21 16:29:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 17:18:06 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 17:19:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74bcbd548897b81ad7867001e634d6025d2d073f
Cr-Commit-Position: refs/heads/master@{#370720}

Powered by Google App Engine
This is Rietveld 408576698