Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: net/cookies/cookie_monster.h

Issue 1607473010: Match definition and declaration order of CookieMonster methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/cookies/cookie_monster.cc » ('j') | net/cookies/cookie_monster.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cookies/cookie_monster.h
diff --git a/net/cookies/cookie_monster.h b/net/cookies/cookie_monster.h
index 94c3813b4a2f0b66506ce0bddb5c19f4e74e19a1..320ee6671a1f25853a7058bb13ed2d0850647b53 100644
--- a/net/cookies/cookie_monster.h
+++ b/net/cookies/cookie_monster.h
@@ -204,19 +204,6 @@ class NET_EXPORT CookieMonster : public CookieStore {
void DeleteCanonicalCookieAsync(const CanonicalCookie& cookie,
const DeleteCookieCallback& callback);
- // Resets the list of cookieable schemes to the supplied schemes. Does
- // nothing if called after first use of the instance (i.e. after the
- // instance initialization process).
- void SetCookieableSchemes(const char* const schemes[], size_t num_schemes);
-
- // Instructs the cookie monster to not delete expired cookies. This is used
- // in cases where the cookie monster is used as a data structure to keep
- // arbitrary cookies.
- void SetKeepExpiredCookies();
-
- // Protects session cookies from deletion on shutdown.
- void SetForceKeepSessionState();
-
// Flush the backing store (if any) to disk and post the given callback when
// done.
// WARNING: THE CALLBACK WILL RUN ON A RANDOM THREAD. IT MUST BE THREAD SAFE.
@@ -278,18 +265,24 @@ class NET_EXPORT CookieMonster : public CookieStore {
CookieMonster* GetCookieMonster() override;
+ // Resets the list of cookieable schemes to the supplied schemes. Does
+ // nothing if called after first use of the instance (i.e. after the
+ // instance initialization process).
+ void SetCookieableSchemes(const char* const schemes[], size_t num_schemes);
+
+ // Instructs the cookie monster to not delete expired cookies. This is used
+ // in cases where the cookie monster is used as a data structure to keep
+ // arbitrary cookies.
+ void SetKeepExpiredCookies();
+
+ // Protects session cookies from deletion on shutdown.
+ void SetForceKeepSessionState();
+
// Enables writing session cookies into the cookie database. If this this
// method is called, it must be called before first use of the instance
// (i.e. as part of the instance initialization process).
void SetPersistSessionCookies(bool persist_session_cookies);
- // Debugging method to perform various validation checks on the map.
- // Currently just checking that there are no null CanonicalCookie pointers
- // in the map.
- // Argument |arg| is to allow retaining of arbitrary data if the CHECKs
- // in the function trip. TODO(rdsmith):Remove hack.
- void ValidateMap(int arg);
mmenke 2016/01/20 22:14:03 I removed this, since this method doesn't actually
Mike West 2016/01/21 09:28:36 These are the best. :)
-
// Determines if the scheme of the URL is a scheme that cookies will be
// stored for.
bool IsCookieableScheme(const std::string& scheme);
@@ -516,6 +509,7 @@ class NET_EXPORT CookieMonster : public CookieStore {
const base::Time& delete_end);
int DeleteAllForHost(const GURL& url);
+
int DeleteAllCreatedBetweenForHost(const base::Time delete_begin,
const base::Time delete_end,
const GURL& url);
« no previous file with comments | « no previous file | net/cookies/cookie_monster.cc » ('j') | net/cookies/cookie_monster.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698