Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1616443003: Add FlushStore to CookieStore interface. (Closed)

Created:
4 years, 11 months ago by mmenke
Modified:
4 years, 11 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@cookie_monster3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add FlushStore to CookieStore interface. This results in consumers no longer having to downcast to CookieMonster to call the method, and is part of the process of removing CookieStore::GetCookieMonster entirely. Also move a lot of the CookieMonster documentation to the corresponding CookieStore methods, and moved methods around to have consistent ordering. BUG=579653 TBR=newt@chromium.org Committed: https://crrev.com/96f3bab913a1a5a972388023bfc3741839670a74 Cr-Commit-Position: refs/heads/master@{#370988}

Patch Set 1 #

Patch Set 2 : Merge, fix stuff #

Patch Set 3 : Fix ios #

Total comments: 2

Patch Set 4 : Add bug id to comment #

Patch Set 5 : fix old comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -69 lines) Patch
M chrome/browser/android/chrome_application.cc View 2 chunks +1 line, -5 lines 0 comments Download
M ios/net/cookies/cookie_store_ios.h View 2 chunks +1 line, -4 lines 0 comments Download
M ios/net/cookies/cookie_store_ios.mm View 1 6 chunks +17 lines, -17 lines 0 comments Download
M ios/net/cookies/cookie_store_ios_unittest.mm View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M net/cookies/cookie_monster.h View 1 2 chunks +3 lines, -36 lines 0 comments Download
M net/cookies/cookie_store.h View 1 2 3 4 4 chunks +26 lines, -5 lines 0 comments Download
M net/cookies/cookie_store_test_helpers.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M net/cookies/cookie_store_test_helpers.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
mmenke
[mkwst]: Please review everything. [droger]: Please review ios (Expect 4-5 of these CLs - this ...
4 years, 11 months ago (2016-01-21 19:44:18 UTC) #4
Mike West
On 2016/01/21 at 19:44:18, mmenke wrote: > [mkwst]: Please review everything. > [droger]: Please review ...
4 years, 11 months ago (2016-01-22 10:37:58 UTC) #5
droger
ios/net LGTM
4 years, 11 months ago (2016-01-22 10:46:42 UTC) #6
Mike West
(Tiny nit I forgot to publish) https://codereview.chromium.org/1616443003/diff/60001/net/cookies/cookie_store.h File net/cookies/cookie_store.h (right): https://codereview.chromium.org/1616443003/diff/60001/net/cookies/cookie_store.h#newcode113 net/cookies/cookie_store.h:113: // be invoked ...
4 years, 11 months ago (2016-01-22 12:59:47 UTC) #7
mmenke
Thanks for the reviews! On 2016/01/22 10:37:58, Mike West wrote: > On 2016/01/21 at 19:44:18, ...
4 years, 11 months ago (2016-01-22 16:02:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616443003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616443003/80001
4 years, 11 months ago (2016-01-22 16:03:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616443003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616443003/100001
4 years, 11 months ago (2016-01-22 16:07:05 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:100001)
4 years, 11 months ago (2016-01-22 17:34:12 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 17:35:56 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/96f3bab913a1a5a972388023bfc3741839670a74
Cr-Commit-Position: refs/heads/master@{#370988}

Powered by Google App Engine
This is Rietveld 408576698