Add FlushStore to CookieStore interface.

Add FlushStore to CookieStore interface.

This results in consumers no longer having to downcast to
CookieMonster to call the method, and is part of the process
of removing CookieStore::GetCookieMonster entirely.

Also move a lot of the CookieMonster documentation to
the corresponding CookieStore methods, and moved methods
around to have consistent ordering.

BUG=579653
TBR=newt@chromium.org

Committed: https://crrev.com/96f3bab913a1a5a972388023bfc3741839670a74
Cr-Commit-Position: refs/heads/master@{#370988}

[mmenke, 2016-01-21 19:09:51]

Patchset #3 (id:40001) has been deleted

[mmenke, 2016-01-21 19:38:35]

Description was changed from

==========
Add FlushStore to CookieStore interface.

This results in consumers no longer having to downcast to
CookieMonster to call the method, and is part of the process
of removing CookieStore::GetCookieMonster entirely.

BUG=579653
==========

to

==========
Add FlushStore to CookieStore interface.

This results in consumers no longer having to downcast to
CookieMonster to call the method, and is part of the process
of removing CookieStore::GetCookieMonster entirely.

Also move a lot of the CookieMonster documentation to
the corresponding CookieStore methods.

BUG=579653
==========

[mmenke, 2016-01-21 19:44:18]

mmenke@chromium.org changed reviewers:
+ droger@chromium.org, mkwst@chromium.org, newt@chromium.org

[mmenke, 2016-01-21 19:44:18]

[mkwst]:  Please review everything.
[droger]:  Please review ios (Expect 4-5 of these CLs - this is more about
making chrome/ use CookieStore instead of CookiesStore::GetCookieMonster()
everywhere, as opposed to adding functionality on iOS).
[newt]:  I've modified chrome/browser/android/chrome_application.cc to use the
CookieStore parent class instead of CookieMonster.  Feel free to review if you
want, but I'll just TBR you if I don't hear from you in a day.

[Mike West, 2016-01-22 10:37:58]

On 2016/01/21 at 19:44:18, mmenke wrote:
> [mkwst]:  Please review everything.
> [droger]:  Please review ios (Expect 4-5 of these CLs - this is more about
making chrome/ use CookieStore instead of CookiesStore::GetCookieMonster()
everywhere, as opposed to adding functionality on iOS).
> [newt]:  I've modified chrome/browser/android/chrome_application.cc to use the
CookieStore parent class instead of CookieMonster.  Feel free to review if you
want, but I'll just TBR you if I don't hear from you in a day.

LGTM. You might also add a note to the CL description that you moved some
methods around to match the .h ordering, but that's fairly trivial. Thanks!

[droger, 2016-01-22 10:46:42]

ios/net LGTM

[Mike West, 2016-01-22 12:59:47]

(Tiny nit I forgot to publish)

https://codereview.chromium.org/1616443003/diff/60001/net/cookies/cookie_store.h
File net/cookies/cookie_store.h (right):

https://codereview.chromium.org/1616443003/diff/60001/net/cookies/cookie_stor...
net/cookies/cookie_store.h:113: // be invoked on the CookieStore's thread, and
this comment can be removed.
Nit: Can you put a bug ID in here?

[mmenke, 2016-01-22 16:02:06]

Description was changed from

==========
Add FlushStore to CookieStore interface.

This results in consumers no longer having to downcast to
CookieMonster to call the method, and is part of the process
of removing CookieStore::GetCookieMonster entirely.

Also move a lot of the CookieMonster documentation to
the corresponding CookieStore methods.

BUG=579653
==========

to

==========
Add FlushStore to CookieStore interface.

This results in consumers no longer having to downcast to
CookieMonster to call the method, and is part of the process
of removing CookieStore::GetCookieMonster entirely.

Also move a lot of the CookieMonster documentation to
the corresponding CookieStore methods, and moved methods
around to have consistent ordering.

BUG=579653
==========

[mmenke, 2016-01-22 16:02:55]

Thanks for the reviews!

On 2016/01/22 10:37:58, Mike West wrote:
> On 2016/01/21 at 19:44:18, mmenke wrote:
> > [mkwst]:  Please review everything.
> > [droger]:  Please review ios (Expect 4-5 of these CLs - this is more about
> making chrome/ use CookieStore instead of CookiesStore::GetCookieMonster()
> everywhere, as opposed to adding functionality on iOS).
> > [newt]:  I've modified chrome/browser/android/chrome_application.cc to use
the
> CookieStore parent class instead of CookieMonster.  Feel free to review if you
> want, but I'll just TBR you if I don't hear from you in a day.
> 
> LGTM. You might also add a note to the CL description that you moved some
> methods around to match the .h ordering, but that's fairly trivial. Thanks!

Done.

https://codereview.chromium.org/1616443003/diff/60001/net/cookies/cookie_store.h
File net/cookies/cookie_store.h (right):

https://codereview.chromium.org/1616443003/diff/60001/net/cookies/cookie_stor...
net/cookies/cookie_store.h:113: // be invoked on the CookieStore's thread, and
this comment can be removed.
On 2016/01/22 12:59:47, Mike West wrote:
> Nit: Can you put a bug ID in here?

Done.

[mmenke, 2016-01-22 16:03:11]

Description was changed from

==========
Add FlushStore to CookieStore interface.

This results in consumers no longer having to downcast to
CookieMonster to call the method, and is part of the process
of removing CookieStore::GetCookieMonster entirely.

Also move a lot of the CookieMonster documentation to
the corresponding CookieStore methods, and moved methods
around to have consistent ordering.

BUG=579653
==========

to

==========
Add FlushStore to CookieStore interface.

This results in consumers no longer having to downcast to
CookieMonster to call the method, and is part of the process
of removing CookieStore::GetCookieMonster entirely.

Also move a lot of the CookieMonster documentation to
the corresponding CookieStore methods, and moved methods
around to have consistent ordering.

BUG=579653
TBR=newt@chromium.org
==========

[mmenke, 2016-01-22 16:03:24]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2016-01-22 16:03:24]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1616443003/#ps80001
(title: "Add bug id to comment")

[commit-bot: I haz the power, 2016-01-22 16:03:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1616443003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1616443003/80001

[mmenke, 2016-01-22 16:05:41]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2016-01-22 16:06:46]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2016-01-22 16:06:46]

The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1616443003/#ps100001
(title: "fix old comment")

[commit-bot: I haz the power, 2016-01-22 16:07:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1616443003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1616443003/100001

[commit-bot: I haz the power, 2016-01-22 17:34:11]

Description was changed from

==========
Add FlushStore to CookieStore interface.

This results in consumers no longer having to downcast to
CookieMonster to call the method, and is part of the process
of removing CookieStore::GetCookieMonster entirely.

Also move a lot of the CookieMonster documentation to
the corresponding CookieStore methods, and moved methods
around to have consistent ordering.

BUG=579653
TBR=newt@chromium.org
==========

to

==========
Add FlushStore to CookieStore interface.

This results in consumers no longer having to downcast to
CookieMonster to call the method, and is part of the process
of removing CookieStore::GetCookieMonster entirely.

Also move a lot of the CookieMonster documentation to
the corresponding CookieStore methods, and moved methods
around to have consistent ordering.

BUG=579653
TBR=newt@chromium.org
==========

[commit-bot: I haz the power, 2016-01-22 17:34:12]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-01-22 17:35:56]

Description was changed from

==========
Add FlushStore to CookieStore interface.

This results in consumers no longer having to downcast to
CookieMonster to call the method, and is part of the process
of removing CookieStore::GetCookieMonster entirely.

Also move a lot of the CookieMonster documentation to
the corresponding CookieStore methods, and moved methods
around to have consistent ordering.

BUG=579653
TBR=newt@chromium.org
==========

to

==========
Add FlushStore to CookieStore interface.

This results in consumers no longer having to downcast to
CookieMonster to call the method, and is part of the process
of removing CookieStore::GetCookieMonster entirely.

Also move a lot of the CookieMonster documentation to
the corresponding CookieStore methods, and moved methods
around to have consistent ordering.

BUG=579653
TBR=newt@chromium.org

Committed: https://crrev.com/96f3bab913a1a5a972388023bfc3741839670a74
Cr-Commit-Position: refs/heads/master@{#370988}
==========

[commit-bot: I haz the power, 2016-01-22 17:35:56]

Patchset 5 (id:??) landed as
https://crrev.com/96f3bab913a1a5a972388023bfc3741839670a74
Cr-Commit-Position: refs/heads/master@{#370988}