Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Unified Diff: pkg/compiler/lib/src/native/behavior.dart

Issue 1607413002: Revert "dart2js: switching isolate is not 'PURE'" (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart ('k') | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/native/behavior.dart
diff --git a/pkg/compiler/lib/src/native/behavior.dart b/pkg/compiler/lib/src/native/behavior.dart
index 08f1dd9fdf0528799ecf0beef0771be2a6c78773..438dbe6d1797ecdcef10d0ae306075f3c9bfdcab 100644
--- a/pkg/compiler/lib/src/native/behavior.dart
+++ b/pkg/compiler/lib/src/native/behavior.dart
@@ -111,9 +111,6 @@ class NativeBehavior {
static NativeBehavior get PURE => NativeBehavior._makePure();
static NativeBehavior get PURE_ALLOCATION =>
NativeBehavior._makePure(isAllocation: true);
- static NativeBehavior get CHANGES_OTHER => NativeBehavior._makeChangesOther();
- static NativeBehavior get DEPENDS_OTHER => NativeBehavior._makeDependsOther();
-
String toString() {
return 'NativeBehavior('
@@ -135,18 +132,6 @@ class NativeBehavior {
return behavior;
}
- static NativeBehavior _makeChangesOther() {
- // TODO(25544): Have a distinct effect instead of using static properties to
- // model 'other' effects.
- return _makePure()..behavior.sideEffects.setChangesStaticProperty();
- }
-
- static NativeBehavior _makeDependsOther() {
- // TODO(25544): Have a distinct effect instead of using static properties to
- // model 'other' effects.
- return _makePure()..behavior.sideEffects.setDependsStaticProperty();
- }
-
/// Processes the type specification string of a call to JS and stores the
/// result in the [typesReturned] and [typesInstantiated]. It furthermore
/// computes the side effects, and, if given, invokes [setSideEffects] with
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart ('k') | pkg/compiler/lib/src/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698