Revert "dart2js: switching isolate is not 'PURE'"

pkg/compiler/lib/src/native/behavior.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of native;
 
 /// This class is a temporary work-around until we get a more powerful DartType.
 class SpecialType {
   final String name;
   const SpecialType._(this.name);
@@ skipping 93 matching lines @@
   NativeThrowBehavior throwBehavior = NativeThrowBehavior.MAY;
 
   bool isAllocation = false;
   bool useGvn = false;
 
   // TODO(sra): Make NativeBehavior immutable so PURE and PURE_ALLOCATION can be
   // final constant-like objects.
   static NativeBehavior get PURE => NativeBehavior._makePure();
   static NativeBehavior get PURE_ALLOCATION =>
       NativeBehavior._makePure(isAllocation: true);
-  static NativeBehavior get CHANGES_OTHER => NativeBehavior._makeChangesOther();
-  static NativeBehavior get DEPENDS_OTHER => NativeBehavior._makeDependsOther();
-
 
   String toString() {
     return 'NativeBehavior('
         'returns: ${typesReturned}'
         ', creates: ${typesInstantiated}'
         ', sideEffects: ${sideEffects}'
         ', throws: ${throwBehavior}'
         '${isAllocation ? ", isAllocation" : ""}'
         '${useGvn ? ", useGvn" : ""}'
         ')';
   }
 
   static NativeBehavior _makePure({bool isAllocation: false}) {
     NativeBehavior behavior = new NativeBehavior();
     behavior.sideEffects.clearAllDependencies();
     behavior.sideEffects.clearAllSideEffects();
     behavior.throwBehavior = NativeThrowBehavior.NEVER;
     behavior.isAllocation = isAllocation;
     return behavior;
   }
 
-  static NativeBehavior _makeChangesOther() {
-    // TODO(25544): Have a distinct effect instead of using static properties to
-    // model 'other' effects.
-    return _makePure()..behavior.sideEffects.setChangesStaticProperty();
-  }
-
-  static NativeBehavior _makeDependsOther() {
-    // TODO(25544): Have a distinct effect instead of using static properties to
-    // model 'other' effects.
-    return _makePure()..behavior.sideEffects.setDependsStaticProperty();
-  }
-
   /// Processes the type specification string of a call to JS and stores the
   /// result in the [typesReturned] and [typesInstantiated]. It furthermore
   /// computes the side effects, and, if given, invokes [setSideEffects] with
   /// the computed effects. If no side effects are encoded in the [specString]
   /// the [setSideEffects] method is not invoked.
   ///
   /// Two forms of the string is supported:
   ///
   /// 1) A single type string of the form 'void', '', 'var' or 'T1|...|Tn' which
   ///    defines the types returned, and, for the last form, the types also
@@ skipping 730 matching lines @@
         MessageKind.GENERIC,
         {'text': "Type '$typeString' not found."});
     return const DynamicType();
   }
 
   static _errorNode(locationNodeOrElement, Parsing parsing) {
     if (locationNodeOrElement is Node) return locationNodeOrElement;
     return locationNodeOrElement.parseNode(parsing);
   }
 }