Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2084)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart

Issue 1607413002: Revert "dart2js: switching isolate is not 'PURE'" (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/native/behavior.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
index c4ce556be84ffa6eaae42a0073f37fe993a4cdc9..4bdc89fb78775e0f8b79477119de6212a2f52929 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart
@@ -2900,7 +2900,7 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
return irBuilder.buildForeignCode(
js.js.parseForeignJS(backend.namer.staticStateHolder),
const <ir.Primitive>[],
- NativeBehavior.DEPENDS_OTHER);
+ NativeBehavior.PURE);
case 'JS_SET_STATIC_STATE':
validateArgumentCount(exactly: 1);
@@ -2910,7 +2910,7 @@ class IrBuilderVisitor extends ast.Visitor<ir.Primitive>
return irBuilder.buildForeignCode(
js.js.parseForeignJS("$isolateName = #"),
<ir.Primitive>[value],
- NativeBehavior.CHANGES_OTHER);
+ NativeBehavior.PURE);
case 'JS_CALL_IN_ISOLATE':
validateArgumentCount(exactly: 2);
« no previous file with comments | « no previous file | pkg/compiler/lib/src/native/behavior.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698