Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1647)

Unified Diff: tools/gn/ninja_target_writer.cc

Issue 1606553002: Add support for Mac/iOS application bundles to GN tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add unit tests & support for bundle_data_filter Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/ninja_target_writer.cc
diff --git a/tools/gn/ninja_target_writer.cc b/tools/gn/ninja_target_writer.cc
index 6c5d12b05c020e52bc9f6aaa587363dae4165d82..9719f4ee2bcee0de6b02fd9051a03ccda2545e24 100644
--- a/tools/gn/ninja_target_writer.cc
+++ b/tools/gn/ninja_target_writer.cc
@@ -57,8 +57,12 @@ void NinjaTargetWriter::RunAndWriteFile(const Target* target) {
std::stringstream file;
// Call out to the correct sub-type of writer.
- if (target->output_type() == Target::COPY_FILES) {
- NinjaCopyTargetWriter writer(target, file);
+ if (target->output_type() == Target::COPY_FILES ||
+ target->output_type() == Target::COPY_BUNDLE_DATA) {
+ Toolchain::ToolType tool_type = target->output_type() == Target::COPY_FILES
+ ? Toolchain::TYPE_COPY
+ : Toolchain::TYPE_COPY_BUNDLE_DATA;
+ NinjaCopyTargetWriter writer(target, file, tool_type);
writer.Run();
} else if (target->output_type() == Target::ACTION ||
target->output_type() == Target::ACTION_FOREACH) {

Powered by Google App Engine
This is Rietveld 408576698