tools/gn/runtime_deps.cc - Issue 1606553002: Add support for Mac/iOS application bundles to GN tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/runtime_deps.cc

Issue 1606553002: Add support for Mac/iOS application bundles to GN tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add unit tests & support for bundle_data_filter Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/runtime_deps.cc

diff --git a/tools/gn/runtime_deps.cc b/tools/gn/runtime_deps.cc

index d82831199fdca5f31529ad73e7d29b955b65e5a3..d5f5e531db6fec948e5effa542f9e65d29571bae 100644

--- a/tools/gn/runtime_deps.cc

+++ b/tools/gn/runtime_deps.cc

@@ -96,7 +96,8 @@ void RecursiveCollectRuntimeDeps(const Target* target,

if (is_target_data_dep &&

(target->output_type() == Target::ACTION ||

target->output_type() == Target::ACTION_FOREACH ||

- target->output_type() == Target::COPY_FILES)) {

+ target->output_type() == Target::COPY_FILES ||

+ target->output_type() == Target::COPY_BUNDLE_DATA)) {

std::vector<SourceFile> outputs;

target->action_values().GetOutputsAsSourceFiles(target, &outputs);

for (const auto& output_file : outputs)

« tools/gn/function_toolchain.cc ('K') | « tools/gn/ninja_target_writer.cc ('k') | tools/gn/target.h » ('j') | no next file with comments »