Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: tools/gn/ninja_copy_target_writer_unittest.cc

Issue 1606553002: Add support for Mac/iOS application bundles to GN tool. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add unit tests & support for bundle_data_filter Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/ninja_copy_target_writer_unittest.cc
diff --git a/tools/gn/ninja_copy_target_writer_unittest.cc b/tools/gn/ninja_copy_target_writer_unittest.cc
index e6ec2225dff2838527bdd65e5881a7dafb8805d4..f743cf4be02f4848f88f0ede8fff3ec026d8e8fc 100644
--- a/tools/gn/ninja_copy_target_writer_unittest.cc
+++ b/tools/gn/ninja_copy_target_writer_unittest.cc
@@ -29,7 +29,7 @@ TEST(NinjaCopyTargetWriter, Run) {
ASSERT_TRUE(target.OnResolved(&err));
std::ostringstream out;
- NinjaCopyTargetWriter writer(&target, out);
+ NinjaCopyTargetWriter writer(&target, out, Toolchain::TYPE_COPY);
writer.Run();
const char expected_linux[] =
@@ -59,7 +59,7 @@ TEST(NinjaCopyTargetWriter, ToolchainDeps) {
ASSERT_TRUE(target.OnResolved(&err));
std::ostringstream out;
- NinjaCopyTargetWriter writer(&target, out);
+ NinjaCopyTargetWriter writer(&target, out, Toolchain::TYPE_COPY);
writer.Run();
const char expected_linux[] =
@@ -86,7 +86,7 @@ TEST(NinjaCopyTargetWriter, OrderOnlyDeps) {
ASSERT_TRUE(target.OnResolved(&err));
std::ostringstream out;
- NinjaCopyTargetWriter writer(&target, out);
+ NinjaCopyTargetWriter writer(&target, out, Toolchain::TYPE_COPY);
writer.Run();
const char expected_linux[] =
@@ -98,3 +98,34 @@ TEST(NinjaCopyTargetWriter, OrderOnlyDeps) {
std::string out_str = out.str();
EXPECT_EQ(expected_linux, out_str);
}
+
+// Test that the correct tool is used for copy_bundle_data.
+TEST(NinjaCopyTargetWriter, RunForCopyBundleData) {
+ TestWithScope setup;
+ Err err;
+
+ setup.build_settings()->SetBuildDir(SourceDir("//out/Debug/"));
+ Target target(setup.settings(), Label(SourceDir("//foo/"), "bar"));
+ target.set_output_type(Target::COPY_FILES);
+
+ target.sources().push_back(SourceFile("//foo/input1.txt"));
+ target.sources().push_back(SourceFile("//foo/input2.txt"));
+
+ target.action_values().outputs() =
+ SubstitutionList::MakeForTest("//out/Debug/{{source_name_part}}.out");
+
+ target.SetToolchain(setup.toolchain());
+ ASSERT_TRUE(target.OnResolved(&err));
+
+ std::ostringstream out;
+ NinjaCopyTargetWriter writer(&target, out, Toolchain::TYPE_COPY_BUNDLE_DATA);
+ writer.Run();
+
+ const char expected_linux[] =
+ "build input1.out: copy_bundle_data ../../foo/input1.txt\n"
+ "build input2.out: copy_bundle_data ../../foo/input2.txt\n"
+ "\n"
+ "build obj/foo/bar.stamp: stamp input1.out input2.out\n";
+ std::string out_str = out.str();
+ EXPECT_EQ(expected_linux, out_str);
+}

Powered by Google App Engine
This is Rietveld 408576698