Issue 160628: On bookmark edit, the OK button is now disabled if the entered URL is...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 160628: On bookmark edit, the OK button is now disabled if the entered URL is... (Closed)

Created:
11 years, 4 months ago by John Grabowski

Modified:
9 years, 6 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

On bookmark edit, the OK button is now disabled if the entered URL is invalid (e.g. is the empty string). The Cancel button is never disabled. BUG=http://crbug.com/17006 TEST=Right click on a bookmark button to edit it. Make sure OK is enabled. Set URL to "" (the empty string). Make sure OK is DISabled. Set URL to "x". Make sure OK is enabled. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=22490

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -15 lines)			Patch
M	chrome/app/nibs/BookmarkEditor.xib	View	7 chunks	+21 lines, -4 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_editor_controller.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_editor_controller.mm	View	5 chunks	+43 lines, -7 lines	0 comments	Download
M	chrome/browser/cocoa/bookmark_editor_controller_unittest.mm	View	1 chunk	+15 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages