Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1164)

Unified Diff: chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

Issue 160628: On bookmark edit, the OK button is now disabled if the entered URL is... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/bookmark_editor_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/cocoa/bookmark_editor_controller_unittest.mm
===================================================================
--- chrome/browser/cocoa/bookmark_editor_controller_unittest.mm (revision 22277)
+++ chrome/browser/cocoa/bookmark_editor_controller_unittest.mm (working copy)
@@ -90,14 +90,25 @@
EXPECT_EQ(child->GetURL(), GURL(url_name));
// Change just the URL
+ EXPECT_TRUE([controller okButtonEnabled]);
[controller setDisplayURL:@"http://yellow-sneakers.com/"];
+ EXPECT_TRUE([controller okButtonEnabled]);
[controller ok:nil];
child = parent->GetChild(0);
EXPECT_EQ(child->GetTitle(), L"whamma jamma bamma");
EXPECT_EQ(child->GetURL(), GURL("http://yellow-sneakers.com/"));
-}
+ // Give it a URL which needs fixen up to be valid
+ // (e.g. http:// prefix added)
+ [controller setDisplayURL:@"x"];
+ [controller ok:nil];
+ child = parent->GetChild(0);
+ EXPECT_TRUE(child->GetURL().is_valid());
-
-
-
+ // Confirm OK button enabled/disabled as appropriate.
+ EXPECT_TRUE([controller okButtonEnabled]);
+ [controller setDisplayURL:@""];
+ EXPECT_FALSE([controller okButtonEnabled]);
+ [controller setDisplayURL:@"http://www.cnn.com"];
+ EXPECT_TRUE([controller okButtonEnabled]);
+}
« no previous file with comments | « chrome/browser/cocoa/bookmark_editor_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698