Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Side by Side Diff: chrome/browser/cocoa/bookmark_editor_controller_unittest.mm

Issue 160628: On bookmark edit, the OK button is now disabled if the entered URL is... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/cocoa/bookmark_editor_controller.mm ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h> 5 #import <Cocoa/Cocoa.h>
6 6
7 #include "base/scoped_nsobject.h" 7 #include "base/scoped_nsobject.h"
8 #import "chrome/browser/cocoa/bookmark_editor_controller.h" 8 #import "chrome/browser/cocoa/bookmark_editor_controller.h"
9 #include "chrome/browser/cocoa/browser_test_helper.h" 9 #include "chrome/browser/cocoa/browser_test_helper.h"
10 #import "chrome/browser/cocoa/cocoa_test_helper.h" 10 #import "chrome/browser/cocoa/cocoa_test_helper.h"
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 EXPECT_EQ(child->GetURL(), GURL(url_name)); 83 EXPECT_EQ(child->GetURL(), GURL(url_name));
84 84
85 // Change just the title. 85 // Change just the title.
86 [controller setDisplayName:@"whamma jamma bamma"]; 86 [controller setDisplayName:@"whamma jamma bamma"];
87 [controller ok:nil]; 87 [controller ok:nil];
88 child = parent->GetChild(0); 88 child = parent->GetChild(0);
89 EXPECT_EQ(child->GetTitle(), L"whamma jamma bamma"); 89 EXPECT_EQ(child->GetTitle(), L"whamma jamma bamma");
90 EXPECT_EQ(child->GetURL(), GURL(url_name)); 90 EXPECT_EQ(child->GetURL(), GURL(url_name));
91 91
92 // Change just the URL 92 // Change just the URL
93 EXPECT_TRUE([controller okButtonEnabled]);
93 [controller setDisplayURL:@"http://yellow-sneakers.com/"]; 94 [controller setDisplayURL:@"http://yellow-sneakers.com/"];
95 EXPECT_TRUE([controller okButtonEnabled]);
94 [controller ok:nil]; 96 [controller ok:nil];
95 child = parent->GetChild(0); 97 child = parent->GetChild(0);
96 EXPECT_EQ(child->GetTitle(), L"whamma jamma bamma"); 98 EXPECT_EQ(child->GetTitle(), L"whamma jamma bamma");
97 EXPECT_EQ(child->GetURL(), GURL("http://yellow-sneakers.com/")); 99 EXPECT_EQ(child->GetURL(), GURL("http://yellow-sneakers.com/"));
100
101 // Give it a URL which needs fixen up to be valid
102 // (e.g. http:// prefix added)
103 [controller setDisplayURL:@"x"];
104 [controller ok:nil];
105 child = parent->GetChild(0);
106 EXPECT_TRUE(child->GetURL().is_valid());
107
108 // Confirm OK button enabled/disabled as appropriate.
109 EXPECT_TRUE([controller okButtonEnabled]);
110 [controller setDisplayURL:@""];
111 EXPECT_FALSE([controller okButtonEnabled]);
112 [controller setDisplayURL:@"http://www.cnn.com"];
113 EXPECT_TRUE([controller okButtonEnabled]);
98 } 114 }
99
100
101
102
103
OLDNEW
« no previous file with comments | « chrome/browser/cocoa/bookmark_editor_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698