Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Issue 1606113002: Enable most of the constant AST serialization for AST-based summaries. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable most of the constant AST serialization for AST-based summaries. Class member references - constructors (both ambigue and not) and static methods. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/633b09698d836cac14dd84d04db008076ef34cb5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -76 lines) Patch
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 4 chunks +24 lines, -7 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 4 chunks +13 lines, -68 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-19 23:03:12 UTC) #1
Paul Berry
lgtm
4 years, 11 months ago (2016-01-20 00:04:04 UTC) #2
scheglov
4 years, 11 months ago (2016-01-20 00:15:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
633b09698d836cac14dd84d04db008076ef34cb5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698