Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: pkg/analyzer/test/src/summary/summary_test.dart

Issue 1606113002: Enable most of the constant AST serialization for AST-based summaries. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_elements.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/src/summary/summary_test.dart
diff --git a/pkg/analyzer/test/src/summary/summary_test.dart b/pkg/analyzer/test/src/summary/summary_test.dart
index 305a9eb2970229d390d1a8e2d6e593458a04af00..b66476f97a6536db3bd4cbf0d48643aac8566948 100644
--- a/pkg/analyzer/test/src/summary/summary_test.dart
+++ b/pkg/analyzer/test/src/summary/summary_test.dart
@@ -1475,6 +1475,10 @@ class E {}
}
test_constExpr_invokeConstructor_named() {
+ if (checkAstDerivedData) {
+ // TODO(scheglov) at the moment we cannot link class member references
+ return;
+ }
UnlinkedVariable variable = serializeVariableText('''
class C {
const C.named();
@@ -1494,6 +1498,10 @@ const v = const C.named();
}
test_constExpr_invokeConstructor_named_imported() {
+ if (checkAstDerivedData) {
+ // TODO(scheglov) at the moment we cannot link class member references
+ return;
+ }
addNamedSource(
'/a.dart',
'''
@@ -1812,9 +1820,11 @@ const v = p.a;
_assertUnlinkedConst(variable.constExpr, operators: [
UnlinkedConstOperation.pushReference
], referenceValidators: [
- (UnlinkedTypeRef r) => checkTypeRef(r, absUri('/a.dart'), 'a.dart', 'a',
- expectedKind: ReferenceKind.topLevelPropertyAccessor,
- expectedPrefix: 'p')
+ (UnlinkedTypeRef r) {
+ return checkTypeRef(r, absUri('/a.dart'), 'a.dart', 'a',
+ expectedKind: ReferenceKind.topLevelPropertyAccessor,
+ expectedPrefix: 'p');
+ }
]);
}
@@ -4116,71 +4126,6 @@ class UnlinkedSummarizeAstTest extends Object with SummaryTest {
}
}
- @override
- void test_constExpr_invokeConstructor_named() {
- // TODO(scheglov) remove this method to enable the test
- }
-
- @override
- void test_constExpr_invokeConstructor_named_imported() {
- // TODO(scheglov) remove this method to enable the test
- }
-
- @override
- void test_constExpr_invokeConstructor_named_imported_withPrefix() {
- // TODO(scheglov) remove this method to enable the test
- }
-
- @override
- void test_constExpr_invokeConstructor_unnamed() {
- // TODO(scheglov) remove this method to enable the test
- }
-
- @override
- void test_constExpr_makeList_typed() {
- // TODO(scheglov) remove this method to enable the test
- }
-
- @override
- void test_constExpr_makeList_untyped() {
- // TODO(scheglov) remove this method to enable the test
- }
-
- @override
- void test_constExpr_makeMap_typed() {
- // TODO(scheglov) remove this method to enable the test
- }
-
- @override
- void test_constExpr_makeMap_untyped() {
- // TODO(scheglov) remove this method to enable the test
- }
-
- @override
- void test_constExpr_pushReference_class() {
- // TODO(scheglov) remove this method to enable the test
- }
-
- @override
- void test_constExpr_pushReference_enum() {
- // TODO(scheglov) remove this method to enable the test
- }
-
- @override
- void test_constExpr_pushReference_topLevelVariable_imported() {
- // TODO(scheglov) remove this method to enable the test
- }
-
- @override
- void test_constExpr_pushReference_topLevelVariable_imported_withPrefix() {
- // TODO(scheglov) remove this method to enable the test
- }
-
- @override
- void test_constExpr_pushReference_topLevelVariable_local() {
- // TODO(scheglov) remove this method to enable the test
- }
-
CompilationUnit _parseText(String text) {
CharSequenceReader reader = new CharSequenceReader(text);
Scanner scanner =
« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_elements.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698