pkg/analyzer/lib/src/summary/summarize_const_expr.dart - Issue 1606113002: Enable most of the constant AST serialization for AST-based summaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/summary/summarize_const_expr.dart

Issue 1606113002: Enable most of the constant AST serialization for AST-based summaries. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analyzer/lib/src/summary/summarize_const_expr.dart

diff --git a/pkg/analyzer/lib/src/summary/summarize_const_expr.dart b/pkg/analyzer/lib/src/summary/summarize_const_expr.dart

index 6207521e401f39d26f1e43b16218d6b7c86ea61e..22c92c56a60ccc3929511bb1316fd542b8bb4608 100644

--- a/pkg/analyzer/lib/src/summary/summarize_const_expr.dart

+++ b/pkg/analyzer/lib/src/summary/summarize_const_expr.dart

@@ -63,6 +63,7 @@ abstract class AbstractConstExprSerializer {

operations.add(UnlinkedConstOperation.pushNull);

} else if (expr is Identifier) {

references.add(serializeIdentifier(expr));

+ operations.add(UnlinkedConstOperation.pushReference);

} else if (expr is InstanceCreationExpression) {

_serializeInstanceCreation(expr);

} else if (expr is ListLiteral) {

« no previous file with comments | « pkg/analyzer/lib/src/summary/summarize_ast.dart ('k') | pkg/analyzer/lib/src/summary/summarize_elements.dart » ('j') | no next file with comments »