Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1605473002: Pseudo element ids != NOPSEUDO only in rightmost compound. (Closed)

Created:
4 years, 11 months ago by rune
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@complex-pseudoelm-20160118
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pseudo element ids != NOPSEUDO only in rightmost compound. After landing [1], selectors with pseudo elements will only be valid if the pseudo element is in the rightmost compound. Invalid selectors will be dropped at parse time. Hence, there's no need to check this condition during matching. Also, pseudo element selectors for which CSSSelector::pseudoId() returns NOPSEUDO, are handled in the switch above the modified code. [1] https://codereview.chromium.org/1600793002/ R=esprehn@chromium.org,timloh@chromium.org TEST=CSSSelectorParserTest::InvalidPseudoElementInNonRightmostCompound BUG=489481 Committed: https://crrev.com/04a9adb2a53febc3e9b0c91623da9f2f02c61af3 Cr-Commit-Position: refs/heads/master@{#370356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 1 chunk +4 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
rune
ptal
4 years, 11 months ago (2016-01-18 10:51:17 UTC) #2
esprehn
lgtm
4 years, 11 months ago (2016-01-20 06:40:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605473002/1
4 years, 11 months ago (2016-01-20 08:14:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 09:47:54 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 09:49:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04a9adb2a53febc3e9b0c91623da9f2f02c61af3
Cr-Commit-Position: refs/heads/master@{#370356}

Powered by Google App Engine
This is Rietveld 408576698