Pseudo elements may only appear in rightmost compound.

Pseudo elements may only appear in rightmost compound.

Pseudo elements are appended to an originating element as defined in
Selectors Level 4 and may only be followed by user action pseudo
classes. That means it also must appear in the rightmost compound. We
drop selectors as invalid when trying to add a compound when we have
already seen a pseudo element in a previous compound.

There are expections to this for Blink, where we implement ::content
and ::shadow to pierce through insertion points and shadow boundaries
as pseudo elements. Another exception is for custom pseudo elements in
UA stylesheets, as we rely on exposing inner shadow structure to style
media controls and VTT track regions (crbug.com/578131).

R=timloh@chromium.org
BUG=489481
Committed: https://crrev.com/c8fd6bd1740b6dca0fdca3a8c0171a4206e73a16
Cr-Commit-Position: refs/heads/master@{#370088}

[rune, 2016-01-18 10:01:12]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-18 10:02:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1600793002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1600793002/1

[rune, 2016-01-18 10:51:35]

ptal

[commit-bot: I haz the power, 2016-01-18 11:16:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-18 11:16:27]

Dry run: This issue passed the CQ dry run.

[Timothy Loh, 2016-01-19 04:59:27]

https://codereview.chromium.org/1600793002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp (right):

https://codereview.chromium.org/1600793002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp:136:
HasPseudoElementForRightmostCompound = 1 << 1,
Shouldn't we start counting from 1 << 0?

[Timothy Loh, 2016-01-19 05:32:24]

oh, and lgtm, forgot about that :/

[rune, 2016-01-19 08:41:51]

https://codereview.chromium.org/1600793002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp (right):

https://codereview.chromium.org/1600793002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp:136:
HasPseudoElementForRightmostCompound = 1 << 1,
On 2016/01/19 04:59:27, Timothy Loh wrote:
> Shouldn't we start counting from 1 << 0?

Done.

[rune, 2016-01-19 08:41:56]

The CQ bit was checked by rune@opera.com

[rune, 2016-01-19 08:41:57]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1600793002/#ps20001
(title: "Start counting from 0.")

[commit-bot: I haz the power, 2016-01-19 08:42:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1600793002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1600793002/20001

[commit-bot: I haz the power, 2016-01-19 09:52:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-19 09:53:11]

Description was changed from

==========
Pseudo elements may only appear in rightmost compound.

Pseudo elements are appended to an originating element as defined in
Selectors Level 4 and may only be followed by user action pseudo
classes. That means it also must appear in the rightmost compound. We
drop selectors as invalid when trying to add a compound when we have
already seen a pseudo element in a previous compound.

There are expections to this for Blink, where we implement ::content
and ::shadow to pierce through insertion points and shadow boundaries
as pseudo elements. Another exception is for custom pseudo elements in
UA stylesheets, as we rely on exposing inner shadow structure to style
media controls and VTT track regions (crbug.com/578131).

R=timloh@chromium.org
BUG=489481
==========

to

==========
Pseudo elements may only appear in rightmost compound.

Pseudo elements are appended to an originating element as defined in
Selectors Level 4 and may only be followed by user action pseudo
classes. That means it also must appear in the rightmost compound. We
drop selectors as invalid when trying to add a compound when we have
already seen a pseudo element in a previous compound.

There are expections to this for Blink, where we implement ::content
and ::shadow to pierce through insertion points and shadow boundaries
as pseudo elements. Another exception is for custom pseudo elements in
UA stylesheets, as we rely on exposing inner shadow structure to style
media controls and VTT track regions (crbug.com/578131).

R=timloh@chromium.org
BUG=489481

Committed: https://crrev.com/c8fd6bd1740b6dca0fdca3a8c0171a4206e73a16
Cr-Commit-Position: refs/heads/master@{#370088}
==========

[commit-bot: I haz the power, 2016-01-19 09:53:12]

Patchset 2 (id:??) landed as
https://crrev.com/c8fd6bd1740b6dca0fdca3a8c0171a4206e73a16
Cr-Commit-Position: refs/heads/master@{#370088}