Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1605523002: Removed selector matching check for invalid pseudo elements. (Closed)

Created:
4 years, 11 months ago by rune
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh, esprehn
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-pseudoelm-check-1-20160118
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed selector matching check for invalid pseudo elements. The check removed checked that only custom pseudo elements and ::selection allow other simple selectors to follow. This is now handled entirely at parse time. R=esprehn@chromium.org,timloh@chromium.org BUG=489481 Committed: https://crrev.com/95a3ba3929113edff393f11d0b7dd830910696e6 Cr-Commit-Position: refs/heads/master@{#371054}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (7 generated)
rune
ptal
4 years, 11 months ago (2016-01-18 12:23:37 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605523002/1
4 years, 11 months ago (2016-01-20 10:33:29 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-20 11:33:42 UTC) #5
rune
ping
4 years, 11 months ago (2016-01-20 17:49:49 UTC) #6
esprehn
Is it true that querySelector("::content > foo") can never match anything? I think so. lgtm
4 years, 11 months ago (2016-01-22 19:25:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605523002/1
4 years, 11 months ago (2016-01-22 20:55:34 UTC) #11
rune
On 2016/01/22 19:25:41, esprehn wrote: > Is it true that querySelector("::content > foo") can never ...
4 years, 11 months ago (2016-01-22 21:11:08 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 22:09:04 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 22:10:12 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95a3ba3929113edff393f11d0b7dd830910696e6
Cr-Commit-Position: refs/heads/master@{#371054}

Powered by Google App Engine
This is Rietveld 408576698