chrome/browser/ui/webui/media_router/media_router_ui.cc - Issue 1605133002: [Media Router] Handle route creation where resolved route is not for display.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/media_router/media_router_ui.cc

Issue 1605133002: [Media Router] Handle route creation where resolved route is not for display. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per imcheng@'s comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/media_router/media_router_ui_interface.js ('k') | chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/media_router/media_router_ui.cc

diff --git a/chrome/browser/ui/webui/media_router/media_router_ui.cc b/chrome/browser/ui/webui/media_router/media_router_ui.cc

index 7814a68815f2ca8b1effc2d04194f80c8940e151..9ceaded12d2a37d7dadf2aecba9bd26eef842c82 100644

--- a/chrome/browser/ui/webui/media_router/media_router_ui.cc

+++ b/chrome/browser/ui/webui/media_router/media_router_ui.cc

@@ -465,7 +465,8 @@ void MediaRouterUI::OnRouteResponseReceived(const int route_request_id,

DVLOG(0) << "MediaRouteResponse returned error: " << error;

}

- handler_->OnCreateRouteResponseReceived(sink_id, route);

+ std::string route_id = route ? route->media_route_id() : std::string();

+ handler_->OnCreateRouteResponseReceived(sink_id, route_id);

current_route_request_id_ = -1;

route_creation_timer_.Stop();

}