Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/browser/resources/media_router/media_router_ui_interface.js

Issue 1605133002: [Media Router] Handle route creation where resolved route is not for display. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per imcheng@'s comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/media_router_ui_interface.js
diff --git a/chrome/browser/resources/media_router/media_router_ui_interface.js b/chrome/browser/resources/media_router/media_router_ui_interface.js
index fb53eff22931c88d4b0790d2ac71ee572b1123de..4d22488bc15e2d36a81ba40d10d2de2563d93126 100644
--- a/chrome/browser/resources/media_router/media_router_ui_interface.js
+++ b/chrome/browser/resources/media_router/media_router_ui_interface.js
@@ -22,11 +22,11 @@ cr.define('media_router.ui', function() {
*
* @param {string} sinkId The ID of the sink to which the Media Route was
* creating a route.
- * @param {?media_router.Route} route The newly create route to the sink
- * if route creation succeeded; null otherwise
+ * @param {string} routeId The ID of the newly created route that corresponds
+ * to the sink if route creation succeeded; empty otherwise.
*/
- function onCreateRouteResponseReceived(sinkId, route) {
- container.onCreateRouteResponseReceived(sinkId, route);
+ function onCreateRouteResponseReceived(sinkId, routeId) {
+ container.onCreateRouteResponseReceived(sinkId, routeId);
}
/**
@@ -215,6 +215,15 @@ cr.define('media_router.browserApi', function() {
}
/**
+ * Reports whether or not a route was created successfully.
+ *
+ * @param {boolean} success
+ */
+ function reportRouteCreation(success) {
+ chrome.send('reportRouteCreation', [success]);
+ }
+
+ /**
* Reports the cast mode that the user selected.
*
* @param {number} castModeType
@@ -284,6 +293,7 @@ cr.define('media_router.browserApi', function() {
reportInitialState: reportInitialState,
reportNavigateToView: reportNavigateToView,
reportSelectedCastMode: reportSelectedCastMode,
+ reportRouteCreation: reportRouteCreation,
reportSinkCount: reportSinkCount,
reportTimeToClickSink: reportTimeToClickSink,
reportTimeToInitialActionClose: reportTimeToInitialActionClose,
« no previous file with comments | « chrome/browser/resources/media_router/media_router.js ('k') | chrome/browser/ui/webui/media_router/media_router_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698