chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h - Issue 1605133002: [Media Router] Handle route creation where resolved route is not for display.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h

Issue 1605133002: [Media Router] Handle route creation where resolved route is not for display. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per imcheng@'s comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/media_router/media_router_ui.cc ('k') | chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h

diff --git a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h

index e5bec190eac8e8230c44f3c0a0c28c7a643d4739..562ba43a09ee1296ed5acbf1341314d3d5408502 100644

--- a/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h

+++ b/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h

@@ -38,7 +38,7 @@ class MediaRouterWebUIMessageHandler : public content::WebUIMessageHandler {

void UpdateCastModes(const CastModeSet& cast_modes,

const std::string& source_host);

void OnCreateRouteResponseReceived(const MediaSink::Id& sink_id,

- const MediaRoute* route);

+ const MediaRoute::Id& route_id);

// Does not take ownership of |issue|. Note that |issue| can be nullptr, when

// there are no more issues.

@@ -68,6 +68,7 @@ class MediaRouterWebUIMessageHandler : public content::WebUIMessageHandler {

void OnReportInitialAction(const base::ListValue* args);

void OnReportInitialState(const base::ListValue* args);

void OnReportNavigateToView(const base::ListValue* args);

+ void OnReportRouteCreation(const base::ListValue* args);

void OnReportSelectedCastMode(const base::ListValue* args);

void OnReportSinkCount(const base::ListValue* args);

void OnReportTimeToClickSink(const base::ListValue* args);