Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 1605083002: Elim 'new ChromeEvent' from interface generation (Closed)

Created:
4 years, 11 months ago by stevenjb
Modified:
4 years, 11 months ago
Reviewers:
Devlin, Dan Beam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue_563744_line_wrap
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Elim 'new ChromeEvent' from interface generation BUG=563744 Committed: https://crrev.com/ec540bb2fd3b42a490f6d598d33b3428bfda7b9d Cr-Commit-Position: refs/heads/master@{#370601}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M tools/json_schema_compiler/js_interface_generator.py View 1 2 chunks +7 lines, -3 lines 0 comments Download
M tools/json_schema_compiler/js_interface_generator_test.py View 1 chunk +7 lines, -7 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
stevenjb
This may need to be re-factored depending on how we address the line wrapping issues, ...
4 years, 11 months ago (2016-01-19 19:11:46 UTC) #3
Devlin
lgtm
4 years, 11 months ago (2016-01-19 21:50:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1605083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1605083002/20001
4 years, 11 months ago (2016-01-21 01:08:33 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 03:15:33 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ec540bb2fd3b42a490f6d598d33b3428bfda7b9d Cr-Commit-Position: refs/heads/master@{#370601}
4 years, 11 months ago (2016-01-21 03:16:49 UTC) #11
Dan Beam
4 years, 11 months ago (2016-01-21 03:21:17 UTC) #13
Message was sent while issue was closed.
sweet!

Powered by Google App Engine
This is Rietveld 408576698