Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: tools/json_schema_compiler/js_interface_generator_test.py

Issue 1605083002: Elim 'new ChromeEvent' from interface generation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_563744_line_wrap
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/json_schema_compiler/js_interface_generator.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/json_schema_compiler/js_interface_generator_test.py
diff --git a/tools/json_schema_compiler/js_interface_generator_test.py b/tools/json_schema_compiler/js_interface_generator_test.py
index 6821ac4c45398d77b189a589826bd55d2421153a..90837d7a9820da9533881fdbe1abc884dede6c9d 100755
--- a/tools/json_schema_compiler/js_interface_generator_test.py
+++ b/tools/json_schema_compiler/js_interface_generator_test.py
@@ -104,14 +104,14 @@ FakeApi.prototype = {
* @see https://developer.chrome.com/extensions/fakeApi#method-bazGreek
*/
bazGreek: assertNotReached,
+};
- /**
- * Fired when we realize it's a trap!
- * @type {!ChromeEvent}
- * @see https://developer.chrome.com/extensions/fakeApi#event-onTrapDetected
- */
- onTrapDetected: new ChromeEvent(),
-};""" % (datetime.now().year, sys.argv[0]))
+/**
+ * Fired when we realize it's a trap!
+ * @type {!ChromeEvent}
+ * @see https://developer.chrome.com/extensions/fakeApi#event-onTrapDetected
+ */
+FakeApi.prototype.onTrapDetected;""" % (datetime.now().year, sys.argv[0]))
class JsExternGeneratorTest(unittest.TestCase):
def _GetNamespace(self, fake_content, filename):
« no previous file with comments | « tools/json_schema_compiler/js_interface_generator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698