Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Issue 1612643002: Update extension API externs (Closed)

Created:
4 years, 11 months ago by stevenjb
Modified:
4 years, 11 months ago
Reviewers:
Devlin, Dan Beam
CC:
chromium-reviews, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue_563744_line_wrap_interfaces
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update extension API externs Updating after fixing line wrapping in the generator. (Also pulls in a couple small changes not pulled in) BUG=none Committed: https://crrev.com/b1854fe7f420c0f15e680f0de362fb4e26a31710 Cr-Commit-Position: refs/heads/master@{#370604}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/closure_compiler/externs/bluetooth.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/closure_compiler/externs/bluetooth_private.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/closure_compiler/externs/settings_private.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
stevenjb
Minor changes found when testing the new generator.
4 years, 11 months ago (2016-01-20 21:52:38 UTC) #2
Dan Beam
lgtm
4 years, 11 months ago (2016-01-20 23:45:22 UTC) #4
Devlin
lgtm
4 years, 11 months ago (2016-01-20 23:46:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612643002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612643002/20001
4 years, 11 months ago (2016-01-21 01:12:22 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-21 03:22:44 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 03:23:43 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b1854fe7f420c0f15e680f0de362fb4e26a31710
Cr-Commit-Position: refs/heads/master@{#370604}

Powered by Google App Engine
This is Rietveld 408576698