Issue 16049009: [autofill] Show autofill suggestions on tap gesture.

Issue 16049009: [autofill] Show autofill suggestions on tap gesture. (Closed)

Created:
7 years, 6 months ago by nyquist

Modified:
6 years, 8 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, nilesh

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[autofill] Show autofill suggestions on tap gesture. Users of touch-only devices currently have no way of getting autofill suggestions other than start typing in the field. This adds the possibility to just tap in the field to get suggestions as a dropdown for those platforms. For platforms that both have touch and mouse input, this will also enable them to use a tap to interact with autofill suggestions. When they are already tapping on the screen, it is likely they will also select autofill suggetions using a tap gesture. BUG=176386

Patch Set 1 #

Patch Set 2 : Fixed compile errors for tests #

Total comments: 3

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -17 lines)			Patch
M	chrome/renderer/autofill/autofill_renderer_browsertest.cc	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/renderer/autofill/page_click_tracker_browsertest.cc	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	components/autofill/renderer/autofill_agent.h	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	components/autofill/renderer/autofill_agent.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	components/autofill/renderer/page_click_listener.h	View		2 chunks	+8 lines, -1 line	0 comments	Download
M	components/autofill/renderer/page_click_tracker.h	View		3 chunks	+12 lines, -1 line	1 comment	Download
M	components/autofill/renderer/page_click_tracker.cc	View		2 chunks	+20 lines, -5 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

7 years, 6 months ago (2013-06-06 20:35:08 UTC) #2

Please add some test coverage for this.  Also, please file a bug specifically
for this change, and update the bug in the CL description to reference that one.

https://codereview.chromium.org/16049009/diff/3001/components/autofill/render...
File components/autofill/renderer/page_click_tracker.cc (right):

https://codereview.chromium.org/16049009/diff/3001/components/autofill/render...
components/autofill/renderer/page_click_tracker.cc:82:
autofill::InputEventSource source) {
nit: No need for the "autofill::" prefix, as this code is already in the
autofill namespace.

https://codereview.chromium.org/16049009/diff/3001/components/autofill/render...
components/autofill/renderer/page_click_tracker.cc:85: }
nit: No need for curlies

https://codereview.chromium.org/16049009/diff/3001/components/autofill/render...
File components/autofill/renderer/page_click_tracker.h (right):

https://codereview.chromium.org/16049009/diff/3001/components/autofill/render...
components/autofill/renderer/page_click_tracker.h:63: autofill::InputEventSource
source);
nit: No need for the "autofill::" prefix, as this code is already in the
autofill namespace.

Expand Messages | Collapse Messages