[autofill] Show autofill suggestions on tap gesture.

components/autofill/renderer/page_click_tracker.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/renderer/page_click_tracker.h"
 
 #include "components/autofill/renderer/form_autofill_util.h"
 #include "components/autofill/renderer/page_click_listener.h"
 #include "content/public/renderer/render_view.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDOMMouseEvent.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDocument.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebInputElement.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebInputEvent.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
 
 using WebKit::WebDOMEvent;
 using WebKit::WebDOMMouseEvent;
 using WebKit::WebElement;
 using WebKit::WebFormControlElement;
 using WebKit::WebFrame;
+using WebKit::WebGestureEvent;
 using WebKit::WebInputElement;
 using WebKit::WebInputEvent;
 using WebKit::WebMouseEvent;
+using WebKit::WebTouchEvent;
 using WebKit::WebNode;
 using WebKit::WebString;
 using WebKit::WebView;
 
 namespace {
 
 // Casts |node| to a WebInputElement.
 // Returns an empty (isNull()) WebInputElement if |node| is not a text field.
 const WebInputElement GetTextWebInputElement(const WebNode& node) {
   if (!node.isElementNode())
@@ skipping 31 matching lines @@
 
 PageClickTracker::~PageClickTracker() {
   // Note that even though RenderView calls FrameDetached when notified that
   // a frame was closed, it might not always get that notification from WebKit
   // for all frames.
   // By the time we get here, the frame could have been destroyed so we cannot
   // unregister listeners in frames remaining in tracked_frames_ as they might
   // be invalid.
 }
 
-void PageClickTracker::DidHandleMouseEvent(const WebMouseEvent& event) {
-  if (event.type != WebInputEvent::MouseDown ||
-      last_node_clicked_.isNull()) {
+void PageClickTracker::DidHandleMouseOrGestureEvent(
+    const WebInputEvent& event,
+    WebInputEvent::Type expected_type,
+    autofill::InputEventSource source) {

[Ilya Sherman, 2013/06/06 20:35:08]

nit: No need for the "autofill::" prefix, as this code is already in the
autofill namespace.

+  if (event.type != expected_type || last_node_clicked_.isNull()) {
     return;
   }

[Ilya Sherman, 2013/06/06 20:35:08]

nit: No need for curlies

 
-  // We are only interested in text field clicks.
+  // We are only interested in text field clicks and taps.
   const WebInputElement input_element =
       GetTextWebInputElement(last_node_clicked_);
   if (input_element.isNull())
     return;
 
   bool is_focused = (last_node_clicked_ == render_view()->GetFocusedNode());
-  listener_->InputElementClicked(input_element, was_focused_, is_focused);
+  listener_->InputElementClicked(input_element,
+                                 was_focused_,
+                                 is_focused,
+                                 source);
+}
+
+void PageClickTracker::DidHandleMouseEvent(const WebMouseEvent& event) {
+  DidHandleMouseOrGestureEvent(event, WebInputEvent::MouseDown, MOUSE_CLICK);
+}
+
+void PageClickTracker::DidHandleGestureEvent(const WebGestureEvent& event) {
+  DidHandleMouseOrGestureEvent(event, WebInputEvent::GestureTap, TAP_GESTURE);
 }
 
 void PageClickTracker::DidFinishDocumentLoad(WebKit::WebFrame* frame) {
   tracked_frames_.push_back(frame);
   frame->document().addEventListener("mousedown", this, false);
 }
 
 void PageClickTracker::FrameDetached(WebKit::WebFrame* frame) {
   std::vector<WebKit::WebFrame*>::iterator iter =
       std::find(tracked_frames_.begin(), tracked_frames_.end(), frame);
@@ skipping 36 matching lines @@
   was_focused_ = (node.document().focusedNode() == last_node_clicked_);
 }
 
 void PageClickTracker::HandleTextFieldMaybeLosingFocus(
     const WebNode& newly_clicked_node) {
   if (DidSelectedTextFieldLoseFocus(newly_clicked_node))
     listener_->InputElementLostFocus();
 }
 
 }  // namespace autofill