Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: components/autofill/renderer/page_click_tracker.h

Issue 16049009: [autofill] Show autofill suggestions on tap gesture. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed compile errors for tests Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/renderer/page_click_tracker.h
diff --git a/components/autofill/renderer/page_click_tracker.h b/components/autofill/renderer/page_click_tracker.h
index 009ce9b512005f5c30e86d3986193071742adbfd..6782278767c4899e692d315f0ef3ec5874d1277c 100644
--- a/components/autofill/renderer/page_click_tracker.h
+++ b/components/autofill/renderer/page_click_tracker.h
@@ -8,8 +8,10 @@
#include <vector>
#include "base/basictypes.h"
+#include "components/autofill/renderer/page_click_listener.h"
#include "content/public/renderer/render_view_observer.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebDOMEventListener.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebInputEvent.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebNode.h"
namespace autofill {
@@ -41,7 +43,10 @@ class PageClickTracker : public content::RenderViewObserver,
// RenderView::Observer implementation.
virtual void DidFinishDocumentLoad(WebKit::WebFrame* frame) OVERRIDE;
virtual void FrameDetached(WebKit::WebFrame* frame) OVERRIDE;
- virtual void DidHandleMouseEvent(const WebKit::WebMouseEvent& event) OVERRIDE;
+ virtual void DidHandleMouseEvent(
+ const WebKit::WebMouseEvent& event) OVERRIDE;
+ virtual void DidHandleGestureEvent(
+ const WebKit::WebGestureEvent& event) OVERRIDE;
// WebKit::WebDOMEventListener implementation.
virtual void handleEvent(const WebKit::WebDOMEvent& event);
@@ -51,6 +56,12 @@ class PageClickTracker : public content::RenderViewObserver,
void HandleTextFieldMaybeLosingFocus(
const WebKit::WebNode& newly_clicked_node);
+ // Helper method for DidHandleMouseEvent and DidHandleGestureEvent.
+ void DidHandleMouseOrGestureEvent(
+ const WebKit::WebInputEvent& event,
+ WebKit::WebInputEvent::Type expected_type,
+ autofill::InputEventSource source);
Ilya Sherman 2013/06/06 20:35:08 nit: No need for the "autofill::" prefix, as this
+
// The last node that was clicked and had focus.
WebKit::WebNode last_node_clicked_;

Powered by Google App Engine
This is Rietveld 408576698