Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Issue 1604853004: Rename slot.getDistributedNodes() to slot.getAssingedNodes({flatten: true}). (Closed)

Created:
4 years, 11 months ago by hayato
Modified:
4 years, 11 months ago
Reviewers:
tkent, kochi
CC:
chromium-reviews, blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename slot.getDistributedNodes() to slot.getAssingedNodes({flatten: true}). The spec is: https://w3c.github.io/webcomponents/spec/shadow/#idl-def-HTMLSlotElement The spec discussion is: https://github.com/w3c/webcomponents/issues/323 HTMLSlotElement.getDistributedNodes() was gone. Now it is available as HTMLSlotElement.getAssignedNodes{{flatten: true}) BUG=531990 Committed: https://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567 Cr-Commit-Position: refs/heads/master@{#370360}

Patch Set 1 #

Patch Set 2 : Add a test for {flattern: false} #

Patch Set 3 : minor #

Total comments: 4

Patch Set 4 : addressed #

Patch Set 5 : minor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -53 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/shadow/v1-default-slots.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-1.html View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-2.html View 1 1 chunk +12 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-with-closed-shadow-tree.html View 1 2 3 4 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-dom-mutation.html View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-fallback-api-1.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-fallback-api-2.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-fallback-api-3.html View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-text-nodes.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/core/html/AssignedNodesOptions.idl View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSlotElement.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 33 (19 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1604853004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1604853004/1
4 years, 11 months ago (2016-01-20 07:04:27 UTC) #2
hayato
Add a test for {flattern: false}
4 years, 11 months ago (2016-01-20 07:24:45 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1604853004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1604853004/20001
4 years, 11 months ago (2016-01-20 07:25:33 UTC) #9
hayato
minor
4 years, 11 months ago (2016-01-20 07:41:26 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1604853004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1604853004/40001
4 years, 11 months ago (2016-01-20 07:41:53 UTC) #16
hayato
PTAL
4 years, 11 months ago (2016-01-20 07:48:20 UTC) #18
kochi
lgtm with nits https://codereview.chromium.org/1604853004/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-with-closed-shadow-tree.html File third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-with-closed-shadow-tree.html (right): https://codereview.chromium.org/1604853004/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-with-closed-shadow-tree.html#newcode55 third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-with-closed-shadow-tree.html:55: }, "A closed shadow tree has ...
4 years, 11 months ago (2016-01-20 08:03:16 UTC) #19
hayato
addressed
4 years, 11 months ago (2016-01-20 08:27:32 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1604853004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1604853004/60001
4 years, 11 months ago (2016-01-20 08:28:10 UTC) #22
hayato
minor
4 years, 11 months ago (2016-01-20 08:28:39 UTC) #24
hayato
https://codereview.chromium.org/1604853004/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-with-closed-shadow-tree.html File third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-with-closed-shadow-tree.html (right): https://codereview.chromium.org/1604853004/diff/40001/third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-with-closed-shadow-tree.html#newcode55 third_party/WebKit/LayoutTests/fast/dom/shadow/v1-slots-api-with-closed-shadow-tree.html:55: }, "A closed shadow tree has nothing to do ...
4 years, 11 months ago (2016-01-20 08:29:07 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1604853004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1604853004/80001
4 years, 11 months ago (2016-01-20 08:29:37 UTC) #29
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 11 months ago (2016-01-20 10:21:09 UTC) #31
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 10:21:54 UTC) #33
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/5dac0e9ab63948cef54619661edc119739ac5567
Cr-Commit-Position: refs/heads/master@{#370360}

Powered by Google App Engine
This is Rietveld 408576698