third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h - Issue 1602773006: blink: Make WebMainThreadScrollingReason wrap the cc enum.

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

Issue 1602773006: blink: Make WebMainThreadScrollingReason wrap the cc enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: enumwrap: . Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/blink/web_layer_impl.cc ('K') | « cc/input/main_thread_scrolling_reason.h ('k') | third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp » ('j') | third_party/WebKit/Source/platform/scroll/DEPS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

index fd48d40ca406d2b87d091cea458b4ceb8004c3fb..40c53407386de45a5fb57d1678782194287aae75 100644

--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h

@@ -30,8 +30,8 @@

#include "core/layout/LayoutObject.h"

#include "platform/PlatformWheelEvent.h"

#include "platform/geometry/IntRect.h"

+#include "platform/scroll/MainThreadScrollingReason.h"

#include "platform/scroll/ScrollTypes.h"

-#include "public/platform/WebMainThreadScrollingReason.h"

#include "wtf/Noncopyable.h"

#include "wtf/text/WTFString.h"

@@ -140,7 +140,7 @@ protected:

private:

bool shouldUpdateAfterCompositingChange() const { return m_scrollGestureRegionIsDirty || m_touchEventTargetRectsAreDirty || m_shouldScrollOnMainThreadDirty || frameViewIsDirty(); }

- void setShouldUpdateScrollLayerPositionOnMainThread(MainThreadScrollingReasons);

+ void setShouldUpdateScrollLayerPositionOnMainThread(uint32_t mainThreadScrollingReasons);

bool hasVisibleSlowRepaintViewportConstrainedObjects(FrameView*) const;

@@ -162,7 +162,7 @@ private:

HashSet<const PaintLayer*> m_layersWithTouchRects;

bool m_wasFrameScrollable;

- MainThreadScrollingReasons m_lastMainThreadScrollingReasons;

+ uint32_t m_lastMainThreadScrollingReasons;

esprehn 2016/01/20 00:09:56 we often do // ActualType in a comment so you kno

danakj 2016/01/20 00:15:11 Done. "A set of flags from MainThreadScrollingReas

danakj 2016/01/20 22:38:07 Actually I found there is a MainThreadScrollingRea

};

} // namespace blink