blink: Make WebMainThreadScrollingReason wrap the cc enum.

blink: Make WebMainThreadScrollingReason wrap the cc enum.

This moves the WebMainThreadScrollingReason from public/platform/ to
platform/scroll/, as it is no longer used in the WebLayer API
explicitly, and renames it to just MainThreadScrollingReason. We change
the type to be an alias for the cc type instead of maintaining static
asserts that they match.

Depends on: https://codereview.chromium.org/1604053002/
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0536dbbcab956b879d2bee49f7e4629cf753a9fa
Cr-Commit-Position: refs/heads/master@{#371151}

[danakj, 2016-01-19 23:54:39]

Description was changed from

==========
blink: Make WebMainThreadScrollingReason wrap the cc enum.

This moves the WebMainThreadScrollingReason from public/platform/ to
platform/scroll/, as it is no longer used in the WebLayer API
explicitly, and renames it to just MainThreadScrollingReason. We change
the type to be an alias for the cc type instead of maintaining static
asserts that they match.

R=aelias@chomium.org, esphren@chromium.org, tdresser@chromium.org
==========

to

==========
blink: Make WebMainThreadScrollingReason wrap the cc enum.

This moves the WebMainThreadScrollingReason from public/platform/ to
platform/scroll/, as it is no longer used in the WebLayer API
explicitly, and renames it to just MainThreadScrollingReason. We change
the type to be an alias for the cc type instead of maintaining static
asserts that they match.

R=aelias@chomium.org, esphren@chromium.org, tdresser@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-01-20 00:01:51]

Description was changed from

==========
blink: Make WebMainThreadScrollingReason wrap the cc enum.

This moves the WebMainThreadScrollingReason from public/platform/ to
platform/scroll/, as it is no longer used in the WebLayer API
explicitly, and renames it to just MainThreadScrollingReason. We change
the type to be an alias for the cc type instead of maintaining static
asserts that they match.

R=aelias@chomium.org, esphren@chromium.org, tdresser@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
blink: Make WebMainThreadScrollingReason wrap the cc enum.

This moves the WebMainThreadScrollingReason from public/platform/ to
platform/scroll/, as it is no longer used in the WebLayer API
explicitly, and renames it to just MainThreadScrollingReason. We change
the type to be an alias for the cc type instead of maintaining static
asserts that they match.
==========

[danakj, 2016-01-20 00:01:51]

danakj@chromium.org changed reviewers:
+ aelias@chromium.org, esprehn@chromium.org
- aelias@chomium.org, esphren@chromium.org

[danakj, 2016-01-20 00:03:05]

elliot please review blink
aelias please review cc

https://codereview.chromium.org/1602773006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scroll/DEPS (right):

https://codereview.chromium.org/1602773006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scroll/DEPS:2: "+cc",
I wasn't sure about adding these to public/platform/, doing it in
platform/scroll/ seemed more obvious, and the type isn't needed in public/, so I
moved it here.. let me know if I'm doing it wrong.

[danakj, 2016-01-20 00:03:27]

Description was changed from

==========
blink: Make WebMainThreadScrollingReason wrap the cc enum.

This moves the WebMainThreadScrollingReason from public/platform/ to
platform/scroll/, as it is no longer used in the WebLayer API
explicitly, and renames it to just MainThreadScrollingReason. We change
the type to be an alias for the cc type instead of maintaining static
asserts that they match.
==========

to

==========
blink: Make WebMainThreadScrollingReason wrap the cc enum.

This moves the WebMainThreadScrollingReason from public/platform/ to
platform/scroll/, as it is no longer used in the WebLayer API
explicitly, and renames it to just MainThreadScrollingReason. We change
the type to be an alias for the cc type instead of maintaining static
asserts that they match.

Depends on: https://codereview.chromium.org/1604053002/
==========

[danakj, 2016-01-20 00:04:35]

https://codereview.chromium.org/1602773006/diff/20001/cc/blink/web_layer_impl.cc
File cc/blink/web_layer_impl.cc (right):

https://codereview.chromium.org/1602773006/diff/20001/cc/blink/web_layer_impl...
cc/blink/web_layer_impl.cc:353: // TODO(tdresser): This is comparing less than a
bit flag but that's not valid
tdresser please take a look at this, it appears to be mighty sketchy code (in
TOT).

[aelias_OOO_until_Jul13, 2016-01-20 00:06:49]

lgtm

[esprehn, 2016-01-20 00:09:56]

lgtm

https://codereview.chromium.org/1602773006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h
(right):

https://codereview.chromium.org/1602773006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h:165:
uint32_t m_lastMainThreadScrollingReasons;
we often do // ActualType

in a comment so you know where to look to see what values are possible.

[danakj, 2016-01-20 00:15:11]

https://codereview.chromium.org/1602773006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h
(right):

https://codereview.chromium.org/1602773006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h:165:
uint32_t m_lastMainThreadScrollingReasons;
On 2016/01/20 00:09:56, esprehn wrote:
> we often do // ActualType
> 
> in a comment so you know where to look to see what values are possible.

Done. "A set of flags from MainThreadScrollingReasons"

[danakj, 2016-01-20 00:16:17]

Description was changed from

==========
blink: Make WebMainThreadScrollingReason wrap the cc enum.

This moves the WebMainThreadScrollingReason from public/platform/ to
platform/scroll/, as it is no longer used in the WebLayer API
explicitly, and renames it to just MainThreadScrollingReason. We change
the type to be an alias for the cc type instead of maintaining static
asserts that they match.

Depends on: https://codereview.chromium.org/1604053002/
==========

to

==========
blink: Make WebMainThreadScrollingReason wrap the cc enum.

This moves the WebMainThreadScrollingReason from public/platform/ to
platform/scroll/, as it is no longer used in the WebLayer API
explicitly, and renames it to just MainThreadScrollingReason. We change
the type to be an alias for the cc type instead of maintaining static
asserts that they match.

Depends on: https://codereview.chromium.org/1604053002/
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-01-20 00:16:24]

Patchset #3 (id:40001) has been deleted

[tdresser, 2016-01-20 15:07:07]

LGTM

Thanks a lot!

https://codereview.chromium.org/1602773006/diff/60001/cc/blink/web_layer_impl.cc
File cc/blink/web_layer_impl.cc (right):

https://codereview.chromium.org/1602773006/diff/60001/cc/blink/web_layer_impl...
cc/blink/web_layer_impl.cc:356:
cc::MainThreadScrollingReason::kMaxNonTransientScrollingReason);
Thanks, I'll fix this shortly.

https://codereview.chromium.org/1602773006/diff/60001/cc/input/main_thread_sc...
File cc/input/main_thread_scrolling_reason.h (right):

https://codereview.chromium.org/1602773006/diff/60001/cc/input/main_thread_sc...
cc/input/main_thread_scrolling_reason.h:24: // Transient scrolling reasons.
These are computed for each scroll begin.
Thanks.

https://codereview.chromium.org/1602773006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scroll/MainThreadScrollingReason.h
(right):

https://codereview.chromium.org/1602773006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scroll/MainThreadScrollingReason.h:1: //
Copyright 2015 The Chromium Authors. All rights reserved.
2016!

[danakj, 2016-01-20 22:38:07]

https://codereview.chromium.org/1602773006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h
(right):

https://codereview.chromium.org/1602773006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h:165:
uint32_t m_lastMainThreadScrollingReasons;
On 2016/01/20 00:15:11, danakj wrote:
> On 2016/01/20 00:09:56, esprehn wrote:
> > we often do // ActualType
> > 
> > in a comment so you know where to look to see what values are possible.
> 
> Done. "A set of flags from MainThreadScrollingReasons"

Actually I found there is a MainThreadScrollingReasons typedef at the top of
this file, using that.

https://codereview.chromium.org/1602773006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/scroll/MainThreadScrollingReason.h
(right):

https://codereview.chromium.org/1602773006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/scroll/MainThreadScrollingReason.h:1: //
Copyright 2015 The Chromium Authors. All rights reserved.
On 2016/01/20 15:07:07, tdresser wrote:
> 2016!

Done.

[danakj, 2016-01-22 00:25:47]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-01-22 00:25:47]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org,
esprehn@chromium.org, tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/1602773006/#ps120001
(title: "enumwrap: rebase")

[commit-bot: I haz the power, 2016-01-22 00:26:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1602773006/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1602773006/120001

[danakj, 2016-01-22 02:08:01]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-01-22 23:54:51]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-01-22 23:55:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1602773006/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1602773006/120001

[commit-bot: I haz the power, 2016-01-23 00:48:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-23 00:48:12]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, no
build URL)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, no
build URL)

[danakj, 2016-01-23 00:49:38]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-01-23 00:50:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1602773006/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1602773006/120001

[commit-bot: I haz the power, 2016-01-23 00:57:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-23 00:57:14]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, no
build URL)

[tandrii(chromium), 2016-01-23 01:25:35]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-01-23 01:27:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1602773006/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1602773006/120001

[tandrii(chromium), 2016-01-23 01:49:24]

On 2016/01/23 00:57:14, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, no
> build URL)

there was a problem with these builders, so i've hit cq again.

[commit-bot: I haz the power, 2016-01-23 23:25:00]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-01-23 23:27:10]

Description was changed from

==========
blink: Make WebMainThreadScrollingReason wrap the cc enum.

This moves the WebMainThreadScrollingReason from public/platform/ to
platform/scroll/, as it is no longer used in the WebLayer API
explicitly, and renames it to just MainThreadScrollingReason. We change
the type to be an alias for the cc type instead of maintaining static
asserts that they match.

Depends on: https://codereview.chromium.org/1604053002/
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
blink: Make WebMainThreadScrollingReason wrap the cc enum.

This moves the WebMainThreadScrollingReason from public/platform/ to
platform/scroll/, as it is no longer used in the WebLayer API
explicitly, and renames it to just MainThreadScrollingReason. We change
the type to be an alias for the cc type instead of maintaining static
asserts that they match.

Depends on: https://codereview.chromium.org/1604053002/
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0536dbbcab956b879d2bee49f7e4629cf753a9fa
Cr-Commit-Position: refs/heads/master@{#371151}
==========

[commit-bot: I haz the power, 2016-01-23 23:27:10]

Patchset 6 (id:??) landed as
https://crrev.com/0536dbbcab956b879d2bee49f7e4629cf753a9fa
Cr-Commit-Position: refs/heads/master@{#371151}