Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3316)

Unified Diff: cc/input/main_thread_scrolling_reason.h

Issue 1602773006: blink: Make WebMainThreadScrollingReason wrap the cc enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: enumwrap: . Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/input/main_thread_scrolling_reason.h
diff --git a/cc/input/main_thread_scrolling_reason.h b/cc/input/main_thread_scrolling_reason.h
index 3bc4a9aeccd7e1f6b34925bce4a27f03c4227c4d..3c31a4a66219af0e0475447e3854310fab8c398d 100644
--- a/cc/input/main_thread_scrolling_reason.h
+++ b/cc/input/main_thread_scrolling_reason.h
@@ -7,11 +7,7 @@
namespace cc {
-// Ensure this stays in sync with MainThreadScrollingReason in histograms.xml,
-// and that this extends ScrollingCoordinator::MainThreadScrollingReason.
-// ScrollingCoordinator::MainThreadScrollingReason contains the flags
-// which are associated with a layer. The flags only contained in
-// MainThreadScrollingReason are computed for each scroll begin.
+// Ensure this stays in sync with MainThreadScrollingReason in histograms.xml.
struct MainThreadScrollingReason {
// Non-transient scrolling reasons.
enum : uint32_t { kNotScrollingOnMain = 0 };
@@ -25,7 +21,7 @@ struct MainThreadScrollingReason {
enum : uint32_t { kPageOverlay = 1 << 4 };
enum : uint32_t { kMaxNonTransientScrollingReason = kPageOverlay };
- // Transcient scrolling reasons.
+ // Transient scrolling reasons. These are computed for each scroll begin.
enum : uint32_t { kNonFastScrollableRegion = 1 << 5 };
enum : uint32_t { kEventHandlers = 1 << 6 };
enum : uint32_t { kFailedHitTest = 1 << 7 };

Powered by Google App Engine
This is Rietveld 408576698