Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp

Issue 1602773006: blink: Make WebMainThreadScrollingReason wrap the cc enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: enumwrap: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
diff --git a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
index 4add05313ba6485c1c19645c169c9e875bd631af..84744848cfe370946fd1b638d8113ee47e8be747 100644
--- a/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
+++ b/third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp
@@ -51,6 +51,7 @@
#if OS(MACOSX)
#include "platform/mac/ScrollAnimatorMac.h"
#endif
+#include "platform/scroll/MainThreadScrollingReason.h"
#include "platform/scroll/ScrollAnimatorBase.h"
#include "platform/scroll/ScrollbarTheme.h"
#include "public/platform/Platform.h"
@@ -344,7 +345,7 @@ void ScrollingCoordinator::scrollableAreaScrollbarLayerDidChange(ScrollableArea*
if (!platformSupportsCoordinatedScrollbar) {
if (scrollbarGraphicsLayer) {
WebLayer* scrollbarLayer = toWebLayer(scrollbarGraphicsLayer);
- scrollbarLayer->addMainThreadScrollingReasons(WebMainThreadScrollingReason::ScrollBarScrolling);
+ scrollbarLayer->addMainThreadScrollingReasons(MainThreadScrollingReason::kScrollbarScrolling);
}
return;
}
@@ -399,7 +400,7 @@ bool ScrollingCoordinator::scrollableAreaScrollLayerDidChange(ScrollableArea* sc
// to set the WebLayer's scroll position at fractional precision otherwise the
// WebLayer's position after snapping to device pixel can be off with regard to
// fixed position elements.
- if (m_lastMainThreadScrollingReasons & WebMainThreadScrollingReason::HasNonLayerViewportConstrainedObjects) {
+ if (m_lastMainThreadScrollingReasons & MainThreadScrollingReason::kHasNonLayerViewportConstrainedObjects) {
webLayer->setScrollPositionDouble(DoublePoint(scrollableArea->scrollPosition() - scrollableArea->minimumScrollPosition()));
} else {
DoublePoint scrollPosition(scrollableArea->scrollPositionDouble() - scrollableArea->minimumScrollPositionDouble());
@@ -708,14 +709,14 @@ void ScrollingCoordinator::updateHaveScrollEventHandlers()
}
}
-void ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread(MainThreadScrollingReasons reasons)
+void ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread(MainThreadScrollingReasons mainThreadScrollingReasons)
{
if (!m_page->mainFrame()->isLocalFrame() || !m_page->deprecatedLocalMainFrame()->view())
return;
if (WebLayer* scrollLayer = toWebLayer(m_page->deprecatedLocalMainFrame()->view()->layerForScrolling())) {
- m_lastMainThreadScrollingReasons = reasons;
- if (reasons)
- scrollLayer->addMainThreadScrollingReasons(static_cast<WebMainThreadScrollingReason::WebMainThreadScrollingReason>(reasons));
+ m_lastMainThreadScrollingReasons = mainThreadScrollingReasons;
+ if (mainThreadScrollingReasons)
+ scrollLayer->addMainThreadScrollingReasons(mainThreadScrollingReasons);
else
scrollLayer->clearMainThreadScrollingReasons();
}
@@ -1018,7 +1019,7 @@ MainThreadScrollingReasons ScrollingCoordinator::mainThreadScrollingReasons() co
MainThreadScrollingReasons reasons = static_cast<MainThreadScrollingReasons>(0);
if (!m_page->settings().threadedScrollingEnabled())
- reasons |= WebMainThreadScrollingReason::ThreadedScrollingDisabled;
+ reasons |= MainThreadScrollingReason::kThreadedScrollingDisabled;
if (!m_page->mainFrame()->isLocalFrame())
return reasons;
@@ -1035,7 +1036,7 @@ MainThreadScrollingReasons ScrollingCoordinator::mainThreadScrollingReasons() co
continue;
if (frameView->hasBackgroundAttachmentFixedObjects())
- reasons |= WebMainThreadScrollingReason::HasBackgroundAttachmentFixedObjects;
+ reasons |= MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects;
FrameView::ScrollingReasons scrollingReasons = frameView->scrollingReasons();
const bool mayBeScrolledByInput = (scrollingReasons == FrameView::Scrollable);
const bool mayBeScrolledByScript = mayBeScrolledByInput || (scrollingReasons ==
@@ -1046,7 +1047,7 @@ MainThreadScrollingReasons ScrollingCoordinator::mainThreadScrollingReasons() co
// not let this move there path as an optimization, when we have slow-repaint
// elements.
if (mayBeScrolledByScript && hasVisibleSlowRepaintViewportConstrainedObjects(frameView)) {
- reasons |= WebMainThreadScrollingReason::HasNonLayerViewportConstrainedObjects;
+ reasons |= MainThreadScrollingReason::kHasNonLayerViewportConstrainedObjects;
}
}
@@ -1057,11 +1058,11 @@ String ScrollingCoordinator::mainThreadScrollingReasonsAsText(MainThreadScrollin
{
StringBuilder stringBuilder;
- if (reasons & WebMainThreadScrollingReason::HasBackgroundAttachmentFixedObjects)
+ if (reasons & MainThreadScrollingReason::kHasBackgroundAttachmentFixedObjects)
stringBuilder.appendLiteral("Has background-attachment:fixed, ");
- if (reasons & WebMainThreadScrollingReason::HasNonLayerViewportConstrainedObjects)
+ if (reasons & MainThreadScrollingReason::kHasNonLayerViewportConstrainedObjects)
stringBuilder.appendLiteral("Has non-layer viewport-constrained objects, ");
- if (reasons & WebMainThreadScrollingReason::ThreadedScrollingDisabled)
+ if (reasons & MainThreadScrollingReason::kThreadedScrollingDisabled)
stringBuilder.appendLiteral("Threaded scrolling is disabled, ");
if (stringBuilder.length())

Powered by Google App Engine
This is Rietveld 408576698