third_party/WebKit/Source/modules/webmidi/MIDIController.h - Issue 1602703005: Web MIDI: Ask permissions of the content layer always

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webmidi/MIDIController.h

Issue 1602703005: Web MIDI: Ask permissions of the content layer always (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review #10 and #11, rebase PS will follow Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/midi_dispatcher.cc ('K') | « third_party/WebKit/Source/modules/webmidi/MIDIClient.h ('k') | third_party/WebKit/Source/modules/webmidi/MIDIController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webmidi/MIDIController.h

diff --git a/third_party/WebKit/Source/modules/webmidi/MIDIController.h b/third_party/WebKit/Source/modules/webmidi/MIDIController.h

index 1157eb5eb7729466814b3411d77c5576a623fcc9..14ba3a072e7dcecac39687f726bbf8e5f9ae78be 100644

--- a/third_party/WebKit/Source/modules/webmidi/MIDIController.h

+++ b/third_party/WebKit/Source/modules/webmidi/MIDIController.h

@@ -38,6 +38,7 @@ namespace blink {

class MIDIAccessInitializer;

class MIDIClient;

+class MIDIOptions;

class MIDIController final : public NoBaseWillBeGarbageCollectedFinalized<MIDIController>, public WillBeHeapSupplement<LocalFrame> {

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(MIDIController);

@@ -45,8 +46,8 @@ class MIDIController final : public NoBaseWillBeGarbageCollectedFinalized<MIDICo

public:

virtual ~MIDIController();

- void requestSysexPermission(MIDIAccessInitializer*);

- void cancelSysexPermissionRequest(MIDIAccessInitializer*);

+ void requestPermission(MIDIAccessInitializer*, const MIDIOptions&);

+ void cancelPermissionRequest(MIDIAccessInitializer*);

static PassOwnPtrWillBeRawPtr<MIDIController> create(PassOwnPtr<MIDIClient>);

static const char* supplementName();