third_party/WebKit/Source/modules/webmidi/MIDIController.cpp - Issue 1602703005: Web MIDI: Ask permissions of the content layer always

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webmidi/MIDIController.cpp

Issue 1602703005: Web MIDI: Ask permissions of the content layer always (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review #10 and #11, rebase PS will follow Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/midi_dispatcher.cc ('K') | « third_party/WebKit/Source/modules/webmidi/MIDIController.h ('k') | third_party/WebKit/Source/modules/webmidi/MIDIOptions.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webmidi/MIDIController.cpp

diff --git a/third_party/WebKit/Source/modules/webmidi/MIDIController.cpp b/third_party/WebKit/Source/modules/webmidi/MIDIController.cpp

index d8f8d0ae78e51886cb2c362a829939b8789260ff..09b3054731f6ad147dc2d826150537e6cbebad7d 100644

--- a/third_party/WebKit/Source/modules/webmidi/MIDIController.cpp

+++ b/third_party/WebKit/Source/modules/webmidi/MIDIController.cpp

@@ -55,14 +55,14 @@ PassOwnPtrWillBeRawPtr<MIDIController> MIDIController::create(PassOwnPtr<MIDICli

return adoptPtrWillBeNoop(new MIDIController(client));

}

-void MIDIController::requestSysexPermission(MIDIAccessInitializer* initializer)

+void MIDIController::requestPermission(MIDIAccessInitializer* initializer, const MIDIOptions& options)

{

- m_client->requestSysexPermission(initializer);

+ m_client->requestPermission(initializer, options);

}

-void MIDIController::cancelSysexPermissionRequest(MIDIAccessInitializer* initializer)

+void MIDIController::cancelPermissionRequest(MIDIAccessInitializer* initializer)

{

- m_client->cancelSysexPermissionRequest(initializer);

+ m_client->cancelPermissionRequest(initializer);

}

void provideMIDITo(LocalFrame& frame, PassOwnPtr<MIDIClient> client)