third_party/WebKit/Source/modules/webmidi/MIDIClient.h - Issue 1602703005: Web MIDI: Ask permissions of the content layer always

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webmidi/MIDIClient.h

Issue 1602703005: Web MIDI: Ask permissions of the content layer always (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review #10 and #11, rebase PS will follow Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/midi_dispatcher.cc ('K') | « third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp ('k') | third_party/WebKit/Source/modules/webmidi/MIDIController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webmidi/MIDIClient.h

diff --git a/third_party/WebKit/Source/modules/webmidi/MIDIClient.h b/third_party/WebKit/Source/modules/webmidi/MIDIClient.h

index 25a20a68b21417c79955f7ba17e7e6a2af87a11f..f260923e26a3abd47d4eb87dd92f5115ad691a66 100644

--- a/third_party/WebKit/Source/modules/webmidi/MIDIClient.h

+++ b/third_party/WebKit/Source/modules/webmidi/MIDIClient.h

@@ -38,11 +38,12 @@ namespace blink {

class LocalFrame;

class MIDIAccessInitializer;

+class MIDIOptions;

class MODULES_EXPORT MIDIClient {

public:

- virtual void requestSysexPermission(MIDIAccessInitializer*) = 0;

- virtual void cancelSysexPermissionRequest(MIDIAccessInitializer*) = 0;

+ virtual void requestPermission(MIDIAccessInitializer*, const MIDIOptions&) = 0;

+ virtual void cancelPermissionRequest(MIDIAccessInitializer*) = 0;

virtual ~MIDIClient() { }

};