Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 1602343002: compositor-worker: cc->blink mutation plumbing (Closed)

Created:
4 years, 11 months ago by majidvp
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, f(malita), jam, jbauman+watch_chromium.org, Justin Novosad, kalyank, kinuko+watch, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney, sievers+watch_chromium.org, sof, vmpstr+blinkwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@compositor-worker-ian-patch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

compositor-worker: cc->blink mutation plumbing Add plubming to CC and blink to take a set of compositor mutation from LTHI and apply them to associated elements in blink. Compositor mutations are applied to the DOM element using a custom key frame animation. The following components are added: - CompositorMutatorClient: Maintains current set mutations and provide a callback that is invoked on main thread at begin main frame to trigger application of mutations. - CompositorMutationsTarget: Interface of the components that applies the mutations. - CustomCompositorAnimationManager: Takes a set of mutations and updates their respective elements. - CustomCompositorAnimations: Owns custom keyframe animation for the element and can update it given a mutation. The CompositorMutator and blink->cc plumbing of compositor proxies is in a followup patch: https://codereview.chromium.org/1625473002/ BUG=430155 TESTS=web/tests/CompositorWorkerTest.cpp CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/96452d073371da1e1ab7eb1ef724df0926f76547 Cr-Commit-Position: refs/heads/master@{#386464}

Patch Set 1 #

Patch Set 2 : Fix DEPS issue and some missing methods #

Total comments: 2

Patch Set 3 : Fix test and rebase #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : rebase #

Patch Set 6 : Fix blimp issue #

Total comments: 4

Patch Set 7 : Address Vollick comments #

Total comments: 16

Patch Set 8 : Address review feedback from jbroman@ #

Patch Set 9 : rebase #

Total comments: 1

Patch Set 10 : Use animation machinery instead of updating inline style #

Total comments: 6

Patch Set 11 : Rebase & address esprehn feedback #

Patch Set 12 : Add missing override #

Patch Set 13 : rebase #

Patch Set 14 : Use callbacks instead of plumbing opaque LayerTreeMutations #

Patch Set 15 : Cleanup #

Patch Set 16 : clean up #

Total comments: 2

Patch Set 17 : Remove LayerTreeMutationsCallback and use base::Callback directly #

Patch Set 18 : #

Total comments: 13

Patch Set 19 : Add CompositorMutatorClient and address feedback #

Patch Set 20 : rebase #

Patch Set 21 : Fix export #

Total comments: 7

Patch Set 22 : #

Patch Set 23 : merge master #

Patch Set 24 : Export LayerTreeMutator #

Patch Set 25 : Merge master + s/scoped_ptr/unique_ptr/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+556 lines, -8 lines) Patch
A cc/animation/layer_tree_mutator.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +24 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 5 chunks +12 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 5 chunks +22 lines, -1 line 0 comments Download
M cc/trees/proxy_common.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 2 chunks +4 lines, -0 lines 0 comments Download
M cc/trees/proxy_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +2 lines, -0 lines 0 comments Download
M cc/trees/proxy_main.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/CustomCompositorAnimationManager.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/CustomCompositorAnimationManager.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/CustomCompositorAnimations.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/animation/CustomCompositorAnimations.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +88 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ElementAnimations.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 3 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/ElementAnimations.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 3 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 2 chunks +4 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/CompositorMutationsTarget.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +34 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 1 chunk +43 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/graphics/CompositorMutatorClientTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +46 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DEPS View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/transforms/TransformationMatrix.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 3 chunks +93 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/data/compositor-proxy-basic.html View 1 2 3 4 5 6 7 8 9 10 1 chunk +8 lines, -4 lines 0 comments Download
A third_party/WebKit/public/platform/WebCompositorMutatorClient.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/public/web/WebWidget.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 85 (23 generated)
majidvp
I need to rebase, but please take a look flackr@
4 years, 11 months ago (2016-01-20 16:27:06 UTC) #5
flackr
https://codereview.chromium.org/1602343002/diff/20001/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp File third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp (right): https://codereview.chromium.org/1602343002/diff/20001/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp#newcode253 third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp:253: EXPECT_EQ(String("0.5"), cssValue); It feels strange that you're testing mutating ...
4 years, 11 months ago (2016-01-20 16:50:50 UTC) #6
majidvp
https://codereview.chromium.org/1602343002/diff/20001/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp File third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp (right): https://codereview.chromium.org/1602343002/diff/20001/third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp#newcode253 third_party/WebKit/Source/web/tests/CompositorWorkerTest.cpp:253: EXPECT_EQ(String("0.5"), cssValue); On 2016/01/20 16:50:50, flackr wrote: > It ...
4 years, 11 months ago (2016-01-20 19:23:59 UTC) #7
flackr
https://codereview.chromium.org/1602343002/diff/40001/third_party/WebKit/Source/core/dom/Element.cpp File third_party/WebKit/Source/core/dom/Element.cpp (right): https://codereview.chromium.org/1602343002/diff/40001/third_party/WebKit/Source/core/dom/Element.cpp#newcode1002 third_party/WebKit/Source/core/dom/Element.cpp:1002: TRACE_EVENT0("compositor-worker", "Element::updateFromMutation"); We should have a comment that the ...
4 years, 11 months ago (2016-01-22 14:34:42 UTC) #8
majidvp
On 2016/01/22 14:34:42, flackr wrote: > https://codereview.chromium.org/1602343002/diff/40001/third_party/WebKit/Source/core/dom/Element.cpp > File third_party/WebKit/Source/core/dom/Element.cpp (right): > > https://codereview.chromium.org/1602343002/diff/40001/third_party/WebKit/Source/core/dom/Element.cpp#newcode1002 > ...
4 years, 11 months ago (2016-01-22 21:16:32 UTC) #11
Ian Vollick
A couple of drive-by nits. https://codereview.chromium.org/1602343002/diff/100001/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/1602343002/diff/100001/content/renderer/render_widget.cc#newcode1004 content/renderer/render_widget.cc:1004: TRACE_EVENT0("compositor-worker", "RenderWidget::ApplyMutations"); Please use ...
4 years, 11 months ago (2016-01-22 21:56:53 UTC) #13
majidvp
https://codereview.chromium.org/1602343002/diff/100001/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/1602343002/diff/100001/content/renderer/render_widget.cc#newcode1004 content/renderer/render_widget.cc:1004: TRACE_EVENT0("compositor-worker", "RenderWidget::ApplyMutations"); On 2016/01/22 21:56:53, vollick wrote: > Please ...
4 years, 11 months ago (2016-01-22 23:32:06 UTC) #14
jbroman
I've mostly looked at this from the Blink side of things. I assume the reason ...
4 years, 11 months ago (2016-01-23 23:55:10 UTC) #15
majidvp
> I assume the reason this CL doesn't have end-to-end layout tests yet for > ...
4 years, 11 months ago (2016-01-25 20:40:11 UTC) #16
jbroman
On 2016/01/25 at 20:40:11, majidvp wrote: > > I assume the reason this CL doesn't ...
4 years, 11 months ago (2016-01-26 15:19:48 UTC) #18
majidvp
On 2016/01/26 15:19:48, jbroman wrote: > On 2016/01/25 at 20:40:11, majidvp wrote: > > > ...
4 years, 11 months ago (2016-01-26 15:40:53 UTC) #19
Ian Vollick
On 2016/01/26 15:40:53, majidvp wrote: > On 2016/01/26 15:19:48, jbroman wrote: > > On 2016/01/25 ...
4 years, 11 months ago (2016-01-27 18:56:29 UTC) #21
majidvp
+dtrainor@: For blimp/ review
4 years, 11 months ago (2016-01-27 22:10:32 UTC) #23
David Trainor- moved to gerrit
blimp/ lgtm
4 years, 11 months ago (2016-01-27 22:31:39 UTC) #24
esprehn
I don't think you want to be messing with inline style, this should just be ...
4 years, 11 months ago (2016-01-27 23:00:32 UTC) #25
esprehn
I don't think you want to be messing with inline style, this should just be ...
4 years, 11 months ago (2016-01-27 23:06:52 UTC) #26
piman
https://codereview.chromium.org/1602343002/diff/160001/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://codereview.chromium.org/1602343002/diff/160001/content/renderer/render_widget.cc#newcode1007 content/renderer/render_widget.cc:1007: static_cast<const blink::WebCompositorMutations&>(mutations)); This bothers me a little, because I ...
4 years, 10 months ago (2016-01-29 01:50:09 UTC) #27
majidvp
On 2016/01/27 23:06:52, esprehn wrote: > I don't think you want to be messing with ...
4 years, 10 months ago (2016-02-16 19:19:09 UTC) #28
esprehn
Future patches will remove all the elementId logic and stuff too? https://codereview.chromium.org/1602343002/diff/180001/third_party/WebKit/Source/core/animation/CompositorMutationAnimations.cpp File third_party/WebKit/Source/core/animation/CompositorMutationAnimations.cpp (right): ...
4 years, 10 months ago (2016-02-17 01:32:36 UTC) #29
esprehn
btw all your bots are red...
4 years, 10 months ago (2016-02-17 01:32:44 UTC) #30
esprehn
On 2016/02/16 at 19:19:09, majidvp wrote: > On 2016/01/27 23:06:52, esprehn wrote: > > I ...
4 years, 10 months ago (2016-02-17 01:33:55 UTC) #31
majidvp
On 2016/02/17 01:32:36, esprehn wrote: > Future patches will remove all the elementId logic and ...
4 years, 10 months ago (2016-02-18 14:58:09 UTC) #32
majidvp
piman@: On 2016/01/29 01:50:09, piman wrote: > https://codereview.chromium.org/1602343002/diff/160001/content/renderer/render_widget.cc > File content/renderer/render_widget.cc (right): > > https://codereview.chromium.org/1602343002/diff/160001/content/renderer/render_widget.cc#newcode1007 ...
4 years, 10 months ago (2016-02-18 15:27:47 UTC) #33
majidvp
@esprehn: PTAL. All your comments has been addressed. https://codereview.chromium.org/1602343002/diff/180001/third_party/WebKit/Source/core/animation/CompositorMutationAnimations.cpp File third_party/WebKit/Source/core/animation/CompositorMutationAnimations.cpp (right): https://codereview.chromium.org/1602343002/diff/180001/third_party/WebKit/Source/core/animation/CompositorMutationAnimations.cpp#newcode27 third_party/WebKit/Source/core/animation/CompositorMutationAnimations.cpp:27: static ...
4 years, 10 months ago (2016-02-22 17:59:48 UTC) #34
piman
On 2016/02/18 15:27:47, majidvp wrote: > piman@: > > On 2016/01/29 01:50:09, piman wrote: > ...
4 years, 10 months ago (2016-02-23 00:52:51 UTC) #36
enne (OOO)
> > > In a way, it's the pendant of SwapPromise (just works the other ...
4 years, 10 months ago (2016-02-24 22:42:02 UTC) #37
majidvp
On 2016/02/24 22:42:02, enne wrote: > > > > In a way, it's the pendant ...
4 years, 10 months ago (2016-02-25 22:55:07 UTC) #38
piman
On Thu, Feb 25, 2016 at 2:55 PM, <majidvp@chromium.org> wrote: > On 2016/02/24 22:42:02, enne ...
4 years, 10 months ago (2016-02-25 23:13:55 UTC) #39
piman
On Thu, Feb 25, 2016 at 2:55 PM, <majidvp@chromium.org> wrote: > On 2016/02/24 22:42:02, enne ...
4 years, 10 months ago (2016-02-25 23:13:55 UTC) #40
enne (OOO)
I think the swap promise system is a little bit too specific for the kind ...
4 years, 10 months ago (2016-02-25 23:16:01 UTC) #41
piman
On Thu, Feb 25, 2016 at 3:16 PM, <enne@chromium.org> wrote: > I think the swap ...
4 years, 10 months ago (2016-02-25 23:21:48 UTC) #42
piman
On Thu, Feb 25, 2016 at 3:16 PM, <enne@chromium.org> wrote: > I think the swap ...
4 years, 10 months ago (2016-02-25 23:21:48 UTC) #43
esprehn
Indeed I'd suggest something closer to set_did_scroll_callback, also note that long term blink will hopefully ...
4 years, 10 months ago (2016-02-26 10:06:17 UTC) #44
majidvp
On 2016/02/26 10:06:17, esprehn wrote: > Indeed I'd suggest something closer to set_did_scroll_callback, also note ...
4 years, 9 months ago (2016-03-01 15:46:03 UTC) #47
enne (OOO)
https://codereview.chromium.org/1602343002/diff/300001/cc/animation/layer_tree_mutations_callback.h File cc/animation/layer_tree_mutations_callback.h (right): https://codereview.chromium.org/1602343002/diff/300001/cc/animation/layer_tree_mutations_callback.h#newcode13 cc/animation/layer_tree_mutations_callback.h:13: class LayerTreeMutationsCallback { What does this indirection get you ...
4 years, 9 months ago (2016-03-02 19:55:54 UTC) #48
majidvp
https://codereview.chromium.org/1602343002/diff/300001/cc/animation/layer_tree_mutations_callback.h File cc/animation/layer_tree_mutations_callback.h (right): https://codereview.chromium.org/1602343002/diff/300001/cc/animation/layer_tree_mutations_callback.h#newcode13 cc/animation/layer_tree_mutations_callback.h:13: class LayerTreeMutationsCallback { On 2016/03/02 19:55:54, enne wrote: > ...
4 years, 9 months ago (2016-03-02 21:15:10 UTC) #49
esprehn
kinuko@ can we use base::Bind in platform? I know it's scary with blink types, but ...
4 years, 9 months ago (2016-03-02 21:21:40 UTC) #51
enne (OOO)
I'm pretty sure this is allowed. esprehn can confirm.
4 years, 9 months ago (2016-03-02 21:22:37 UTC) #52
majidvp
esprehn wrote: > > kinuko@ can we use base::Bind in platform? I know it's scary ...
4 years, 9 months ago (2016-03-07 14:45:12 UTC) #53
kinuko
On 2016/03/07 14:45:12, majidvp wrote: > esprehn wrote: > > > kinuko@ can we use ...
4 years, 9 months ago (2016-03-10 01:57:53 UTC) #54
majidvp
On 2016/03/10 01:57:53, kinuko wrote: > On 2016/03/07 14:45:12, majidvp wrote: > > esprehn wrote: ...
4 years, 9 months ago (2016-03-17 15:48:33 UTC) #55
majidvp
enne@: ping
4 years, 9 months ago (2016-03-22 13:33:55 UTC) #56
enne (OOO)
On 2016/03/22 at 13:33:55, majidvp wrote: > enne@: ping Ohmygosh, I'm sorry. I thought I ...
4 years, 9 months ago (2016-03-22 17:26:51 UTC) #57
majidvp
On 2016/03/22 17:26:51, enne wrote: > On 2016/03/22 at 13:33:55, majidvp wrote: > > enne@: ...
4 years, 9 months ago (2016-03-22 17:58:33 UTC) #58
esprehn
Nothing uses the platform/ interface? I don't see any callers. Can we do this in ...
4 years, 9 months ago (2016-03-22 21:16:50 UTC) #59
majidvp
On 2016/03/22 21:16:50, esprehn wrote: > Nothing uses the platform/ interface? I don't see any ...
4 years, 9 months ago (2016-03-22 22:14:40 UTC) #60
majidvp
esprehn@: PTAL https://codereview.chromium.org/1602343002/diff/340001/cc/trees/layer_tree_host_impl.cc File cc/trees/layer_tree_host_impl.cc (right): https://codereview.chromium.org/1602343002/diff/340001/cc/trees/layer_tree_host_impl.cc#newcode3261 cc/trees/layer_tree_host_impl.cc:3261: auto callbacks = make_scoped_ptr(new BeginFrameCallbackList()); On 2016/03/22 ...
4 years, 9 months ago (2016-03-23 22:24:53 UTC) #62
majidvp
@esprehn: friendly ping :)
4 years, 8 months ago (2016-03-29 11:53:17 UTC) #63
esprehn
This patch doesn't seem to create a CustomCompositorAnimationManager (or did I miss it?) your linked ...
4 years, 8 months ago (2016-03-31 05:03:10 UTC) #64
esprehn
This patch doesn't seem to create a CustomCompositorAnimationManager (or did I miss it?) your linked ...
4 years, 8 months ago (2016-03-31 05:03:11 UTC) #65
majidvp
> This patch doesn't seem to create a CustomCompositorAnimationManager (or did I miss it?) your ...
4 years, 8 months ago (2016-03-31 19:43:03 UTC) #66
danakj
https://codereview.chromium.org/1602343002/diff/400001/cc/animation/layer_tree_mutator.h File cc/animation/layer_tree_mutator.h (right): https://codereview.chromium.org/1602343002/diff/400001/cc/animation/layer_tree_mutator.h#newcode18 cc/animation/layer_tree_mutator.h:18: using ApplyMutationsCallback = base::Closure; On 2016/03/31 05:03:11, esprehn wrote: ...
4 years, 8 months ago (2016-04-05 17:41:11 UTC) #67
danakj
https://codereview.chromium.org/1602343002/diff/400001/cc/trees/proxy_main.cc File cc/trees/proxy_main.cc (right): https://codereview.chromium.org/1602343002/diff/400001/cc/trees/proxy_main.cc#newcode188 cc/trees/proxy_main.cc:188: for (auto& callback : *begin_main_frame_state->begin_frame_callbacks) On 2016/03/31 19:43:03, majidvp ...
4 years, 8 months ago (2016-04-05 17:45:21 UTC) #68
majidvp
cc/animation/layer_tree_mutator.h:18: using ApplyMutationsCallback = base::Closure; On 2016/03/31 05:03:11, esprehn wrote: > > why add a ...
4 years, 8 months ago (2016-04-06 23:48:04 UTC) #69
majidvp
@esprehn: Did you get a chance to see my responses in https://codereview.chromium.org/1602343002/#msg66 ? Note the ...
4 years, 8 months ago (2016-04-11 17:09:41 UTC) #70
esprehn
lgtm
4 years, 8 months ago (2016-04-11 17:37:12 UTC) #71
majidvp
On 2016/04/11 17:37:12, esprehn wrote: > lgtm \o/. Thanks to all reviewers for your feedback ...
4 years, 8 months ago (2016-04-11 17:58:18 UTC) #72
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602343002/460001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602343002/460001
4 years, 8 months ago (2016-04-11 17:59:02 UTC) #75
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/185317) ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-11 18:02:37 UTC) #77
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1602343002/480001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1602343002/480001
4 years, 8 months ago (2016-04-11 18:38:19 UTC) #81
commit-bot: I haz the power
Committed patchset #25 (id:480001)
4 years, 8 months ago (2016-04-11 20:36:16 UTC) #83
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 20:38:22 UTC) #85
Message was sent while issue was closed.
Patchset 25 (id:??) landed as
https://crrev.com/96452d073371da1e1ab7eb1ef724df0926f76547
Cr-Commit-Position: refs/heads/master@{#386464}

Powered by Google App Engine
This is Rietveld 408576698