compositor-worker: cc->blink mutation plumbing

third_party/WebKit/Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 20 matching lines @@
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/V8DOMActivityLogger.h"
 #include "bindings/core/v8/V8DOMWrapper.h"
 #include "bindings/core/v8/V8PerContextData.h"
 #include "core/CSSValueKeywords.h"
 #include "core/SVGNames.h"
 #include "core/XLinkNames.h"
 #include "core/XMLNames.h"
 #include "core/animation/AnimationTimeline.h"
 #include "core/animation/css/CSSAnimations.h"
+#include "core/css/CSSFunctionValue.h"
 #include "core/css/CSSImageValue.h"
 #include "core/css/CSSStyleSheet.h"
 #include "core/css/CSSValuePool.h"
 #include "core/css/PropertySetCSSStyleDeclaration.h"
 #include "core/css/StylePropertySet.h"
 #include "core/css/parser/CSSParser.h"
 #include "core/css/resolver/StyleResolver.h"
 #include "core/css/resolver/StyleResolverParentScope.h"
 #include "core/css/resolver/StyleResolverStats.h"
 #include "core/dom/AXObjectCache.h"
@@ skipping 66 matching lines @@
 #include "core/page/scrolling/ScrollCustomizationCallbacks.h"
 #include "core/page/scrolling/ScrollState.h"
 #include "core/page/scrolling/ScrollStateCallback.h"
 #include "core/paint/PaintLayer.h"
 #include "core/svg/SVGDocumentExtensions.h"
 #include "core/svg/SVGElement.h"
 #include "platform/EventDispatchForbiddenScope.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/UserGestureIndicator.h"
 #include "platform/graphics/CompositorMutableProperties.h"
+#include "platform/graphics/CompositorMutation.h"
 #include "platform/scroll/ScrollableArea.h"
+#include "platform/transforms/MatrixTransformOperation.h"

[jbroman, 2016/01/23 23:55:09]

This include doesn't seem to be used; am I missing the use?

[majidvp, 2016/01/25 20:40:10]

removed.

 #include "wtf/BitVector.h"
 #include "wtf/HashFunctions.h"
 #include "wtf/text/CString.h"
 #include "wtf/text/StringBuilder.h"
 #include "wtf/text/TextPosition.h"
 
 namespace blink {
 
 namespace {
 
@@ skipping 849 matching lines @@
 }
 
 void Element::decrementCompositorProxiedProperties(uint32_t mutableProperties)
 {
     ElementRareData& rareData = *elementRareData();
     rareData.decrementCompositorProxiedProperties(mutableProperties);
     if (!rareData.proxiedPropertyCounts())
         setNeedsStyleRecalc(LocalStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::CompositorProxy));
 }
 
+void Element::updateFromMutation(const CompositorMutation& mutation)

[jbroman, 2016/01/23 23:55:09]

Has a core/css/ expert looked at this logic before? If not, I'd suggest having
one (e.g. esprehn, timloh, or rune@opera.com) double-check it.

[majidvp, 2016/01/25 20:40:10]

Not yet, +esprehn@ to check. Basically I see two options for updating the style:
1- Update computed style similar to what happens for compositor-driven CSS
animations
2- Update inline style similar to what happens when user script modifies
element.style.{transform,opacity} in a rAF.

These mutations are coming from user script that is directly manipulating
transform/opacity on the proxies element. So it seemed most appropriate that
they get applied to inline style.

+{
+    ASSERT(isStyledElement());
+    TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("compositor-worker"), "Element::updateFromMutation");
+    // Apply opacity and transform by updating inline style. scroll{Top,Left}
+    // are updated as part of layer tree sync during the commit.
+    if (mutation.isOpacityMutated())
+        setInlineStyleProperty(CSSPropertyOpacity, mutation.opacity(), CSSPrimitiveValue::UnitType::Number);
+    if (mutation.isTransformMutated()) {
+        RefPtrWillBeRawPtr<CSSValueList> valueList(CSSValueList::createSpaceSeparated());
+        RefPtrWillBeRawPtr<CSSFunctionValue> matrixValue(CSSFunctionValue::create(CSSValueMatrix3d));
+        for (int col = 0; col < 4; col++) {
+            for (int row = 0; row < 4; row++) {
+                matrixValue->append(cssValuePool().createValue(mutation.transform().get(row, col), CSSPrimitiveValue::UnitType::Pixels));
+            }
+        }
+        valueList->append(matrixValue.release());
+        ensureMutableInlineStyle().setProperty(CSSPropertyTransform, valueList.release());
+        inlineStyleChanged();
+    }
+}
+
 uint32_t Element::compositorMutableProperties() const
 {
     if (!hasRareData())
         return CompositorMutableProperty::kNone;
     if (CompositorProxiedPropertySet* set = elementRareData()->proxiedPropertyCounts())
         return set->proxiedProperties();
     return CompositorMutableProperty::kNone;
 }
 
 bool Element::hasNonEmptyLayoutSize() const
@@ skipping 2645 matching lines @@
 {
 #if ENABLE(OILPAN)
     if (hasRareData())
         visitor->trace(elementRareData());
     visitor->trace(m_elementData);
 #endif
     ContainerNode::trace(visitor);
 }
 
 } // namespace blink