third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp - Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp

Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/ConsoleMessage.h ('k') | third_party/WebKit/Source/core/inspector/InjectedScriptHost.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp

diff --git a/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp b/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp

index 8636a48fe35bf43f4a74a7c3a9ad4ab8ae35a372..45de46839867fb8c761634fddfec5ebd225251ed 100644

--- a/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp

+++ b/third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp

@@ -90,12 +90,12 @@ void ConsoleMessage::setLineNumber(unsigned lineNumber)

m_lineNumber = lineNumber;

}

-PassRefPtrWillBeRawPtr<ScriptCallStack> ConsoleMessage::callStack() const

+PassRefPtr<ScriptCallStack> ConsoleMessage::callStack() const

{

return m_callStack;

}

-void ConsoleMessage::setCallStack(PassRefPtrWillBeRawPtr<ScriptCallStack> callStack)

+void ConsoleMessage::setCallStack(PassRefPtr<ScriptCallStack> callStack)

{

m_callStack = callStack;

if (m_callStack && m_callStack->size() && !m_scriptId) {

@@ -213,7 +213,6 @@ void ConsoleMessage::collectCallStack()

DEFINE_TRACE(ConsoleMessage)

{

- visitor->trace(m_callStack);

visitor->trace(m_scriptArguments);

}