Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Side by Side Diff: third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp

Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments addressed. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/inspector/ConsoleMessage.h" 5 #include "core/inspector/ConsoleMessage.h"
6 6
7 #include "bindings/core/v8/ScriptCallStackFactory.h" 7 #include "bindings/core/v8/ScriptCallStackFactory.h"
8 #include "bindings/core/v8/ScriptValue.h" 8 #include "bindings/core/v8/ScriptValue.h"
9 #include "core/inspector/ScriptArguments.h" 9 #include "core/inspector/ScriptArguments.h"
10 #include "core/inspector/ScriptAsyncCallStack.h" 10 #include "core/inspector/ScriptAsyncCallStack.h"
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 unsigned ConsoleMessage::lineNumber() const 83 unsigned ConsoleMessage::lineNumber() const
84 { 84 {
85 return m_lineNumber; 85 return m_lineNumber;
86 } 86 }
87 87
88 void ConsoleMessage::setLineNumber(unsigned lineNumber) 88 void ConsoleMessage::setLineNumber(unsigned lineNumber)
89 { 89 {
90 m_lineNumber = lineNumber; 90 m_lineNumber = lineNumber;
91 } 91 }
92 92
93 PassRefPtrWillBeRawPtr<ScriptCallStack> ConsoleMessage::callStack() const 93 PassRefPtr<ScriptCallStack> ConsoleMessage::callStack() const
94 { 94 {
95 return m_callStack; 95 return m_callStack;
96 } 96 }
97 97
98 void ConsoleMessage::setCallStack(PassRefPtrWillBeRawPtr<ScriptCallStack> callSt ack) 98 void ConsoleMessage::setCallStack(PassRefPtr<ScriptCallStack> callStack)
99 { 99 {
100 m_callStack = callStack; 100 m_callStack = callStack;
101 if (m_callStack && m_callStack->size() && !m_scriptId) { 101 if (m_callStack && m_callStack->size() && !m_scriptId) {
102 const ScriptCallFrame& frame = m_callStack->at(0); 102 const ScriptCallFrame& frame = m_callStack->at(0);
103 m_url = frame.sourceURL(); 103 m_url = frame.sourceURL();
104 m_lineNumber = frame.lineNumber(); 104 m_lineNumber = frame.lineNumber();
105 m_columnNumber = frame.columnNumber(); 105 m_columnNumber = frame.columnNumber();
106 } 106 }
107 } 107 }
108 108
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 { 206 {
207 if (m_type == EndGroupMessageType) 207 if (m_type == EndGroupMessageType)
208 return; 208 return;
209 209
210 if (!m_callStack) 210 if (!m_callStack)
211 setCallStack(currentScriptCallStackForConsole(ScriptCallStack::maxCallSt ackSizeToCapture)); 211 setCallStack(currentScriptCallStackForConsole(ScriptCallStack::maxCallSt ackSizeToCapture));
212 } 212 }
213 213
214 DEFINE_TRACE(ConsoleMessage) 214 DEFINE_TRACE(ConsoleMessage)
215 { 215 {
216 visitor->trace(m_callStack);
217 visitor->trace(m_scriptArguments); 216 visitor->trace(m_scriptArguments);
218 } 217 }
219 218
220 } // namespace blink 219 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698