third_party/WebKit/Source/core/inspector/ConsoleMessage.h - Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/ConsoleMessage.h

Issue 1601283003: DevTools: deoilpanize inspector/v8 and related classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/AsyncOperationMap.h ('k') | third_party/WebKit/Source/core/inspector/ConsoleMessage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/ConsoleMessage.h

diff --git a/third_party/WebKit/Source/core/inspector/ConsoleMessage.h b/third_party/WebKit/Source/core/inspector/ConsoleMessage.h

index 383767592a3c0798ab47b76fd07141e55d8d9ee4..131470fde1c7d2dabfb38edbb28606fc8fed7e47 100644

--- a/third_party/WebKit/Source/core/inspector/ConsoleMessage.h

+++ b/third_party/WebKit/Source/core/inspector/ConsoleMessage.h

@@ -39,8 +39,8 @@ public:

void setURL(const String&);

unsigned lineNumber() const;

void setLineNumber(unsigned);

- PassRefPtrWillBeRawPtr<ScriptCallStack> callStack() const;

- void setCallStack(PassRefPtrWillBeRawPtr<ScriptCallStack>);

+ PassRefPtr<ScriptCallStack> callStack() const;

+ void setCallStack(PassRefPtr<ScriptCallStack>);

ScriptState* scriptState() const;

void setScriptState(ScriptState*);

PassRefPtrWillBeRawPtr<ScriptArguments> scriptArguments() const;

@@ -79,7 +79,7 @@ private:

String m_url;

unsigned m_lineNumber;

unsigned m_columnNumber;

- RefPtrWillBeMember<ScriptCallStack> m_callStack;

+ RefPtr<ScriptCallStack> m_callStack;

OwnPtr<ScriptStateProtectingContext> m_scriptState;

RefPtrWillBeMember<ScriptArguments> m_scriptArguments;

unsigned long m_requestIdentifier;