[Resumption 10/12] Use DI::IsDone to check for terminal downloads.

content/public/browser/download_item.h

Index: content/public/browser/download_item.h
diff --git a/content/public/browser/download_item.h b/content/public/browser/download_item.h
index 6c9011007e308591230732608bfe87f18653facc..58f5081d00d4070f4dd4de8348f043de73f14aa4 100644
--- a/content/public/browser/download_item.h
+++ b/content/public/browser/download_item.h
@@ -170,11 +170,14 @@ class CONTENT_EXPORT DownloadItem : public base::SupportsUserData {
   // user-interaction to resume.
   virtual bool CanResume() const = 0;
 
-  //    Convenience routines for accessing GetState() results conceptually -----
-
-  // Returns true if the download needs more data.
+  // Returns true if the download is not in a terminal state. This includes
+  // in-progress downloads as well as interrupted downloads that are currently
+  // resuming or could be resumed. Cancelled or completed downloads are
+  // considered to be in a terminal state.
   virtual bool IsPartialDownload() const = 0;

[Randy Smith (Not in Mondays), 2013/06/05 20:21:44]

Just raising the question: Do we want to keep this name for the method? 
IsPartialDownload() implies to me a method that has to do with how much of the
download has completed.  Maybe we want something more like "IsDone()" or
"IsTerminal()"?  (And reverse all the tests, obviously.)  Your call.

[asanka, 2013/06/05 21:33:47]

Changed to IsDone().

 
+  //    Convenience routines for accessing GetState() results conceptually -----
+
   // Returns true if the download is still receiving data.
   virtual bool IsInProgress() const = 0;