[Resumption 10/12] Use DI::IsDone to check for terminal downloads.

content/public/browser/download_item.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Each download is represented by a DownloadItem, and all DownloadItems
 // are owned by the DownloadManager which maintains a global list of all
 // downloads. DownloadItems are created when a user initiates a download,
 // and exist for the duration of the browser life time.
 //
 // Download observers:
@@ skipping 152 matching lines @@
   virtual DownloadInterruptReason GetLastReason() const = 0;
 
   virtual bool IsPaused() const = 0;
   virtual bool IsTemporary() const = 0;
 
   // Returns true if the download can be resumed. A download can be resumed if
   // an in-progress download was paused or if an interrupted download requires
   // user-interaction to resume.
   virtual bool CanResume() const = 0;
 
+  // Returns true if the download is not in a terminal state. This includes
+  // in-progress downloads as well as interrupted downloads that are currently
+  // resuming or could be resumed. Cancelled or completed downloads are
+  // considered to be in a terminal state.
+  virtual bool IsPartialDownload() const = 0;

[Randy Smith (Not in Mondays), 2013/06/05 20:21:44]

Just raising the question: Do we want to keep this name for the method? 
IsPartialDownload() implies to me a method that has to do with how much of the
download has completed.  Maybe we want something more like "IsDone()" or
"IsTerminal()"?  (And reverse all the tests, obviously.)  Your call.

[asanka, 2013/06/05 21:33:47]

Changed to IsDone().

+
   //    Convenience routines for accessing GetState() results conceptually -----
 
-  // Returns true if the download needs more data.
-  virtual bool IsPartialDownload() const = 0;
-
   // Returns true if the download is still receiving data.
   virtual bool IsInProgress() const = 0;
 
   // Returns true if the download has been cancelled or was interrupted.
   virtual bool IsCancelled() const = 0;
 
   // Returns true if the download was interrupted.
   virtual bool IsInterrupted() const = 0;
 
   // Returns true if we have all the data and know the final file name.
@@ skipping 139 matching lines @@
   // return |name|. Has no effect on the final target filename.
   virtual void SetDisplayName(const base::FilePath& name) = 0;
 
   // Debug/testing -------------------------------------------------------------
   virtual std::string DebugString(bool verbose) const = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_DOWNLOAD_ITEM_H_