[Resumption 10/12] Use DI::IsDone to check for terminal downloads.

chrome/browser/download/download_shelf_context_menu.cc

Index: chrome/browser/download/download_shelf_context_menu.cc
diff --git a/chrome/browser/download/download_shelf_context_menu.cc b/chrome/browser/download/download_shelf_context_menu.cc
index 34e4bbeb90739dc72ca95e9044e3bd49a3f2a2b5..f7555ea2ad481ee6482ce73038ba725ecd82f9e0 100644
--- a/chrome/browser/download/download_shelf_context_menu.cc
+++ b/chrome/browser/download/download_shelf_context_menu.cc
@@ -129,7 +129,7 @@ void DownloadShelfContextMenu::ExecuteCommand(int command_id, int event_flags) {
       // It is possible for the download to complete before the user clicks the
       // menu item, recheck if the download is in progress state before toggling
       // pause.
-      if (download_item_->IsPartialDownload()) {
+      if (download_item_->GetState() == DownloadItem::IN_PROGRESS) {
         if (download_item_->IsPaused())
           download_item_->Resume();
         else
@@ -183,8 +183,7 @@ string16 DownloadShelfContextMenu::GetLabelForCommandId(int command_id) const {
     case SHOW_IN_FOLDER:
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_SHOW);
     case OPEN_WHEN_COMPLETE:
-      if (download_item_ &&
-          download_item_->GetState() == DownloadItem::IN_PROGRESS)
+      if (download_item_ && download_item_->IsPartialDownload())

[Randy Smith (Not in Mondays), 2013/06/05 20:21:44]

Do we persist the open state across browser restarts?

[asanka, 2013/06/05 21:33:47]

We persist the "opened" state, but not the "will open when complete" state.
Added to the list, but I think it's going to be very low priority.

         return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_OPEN_WHEN_COMPLETE);
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_OPEN);
     case ALWAYS_OPEN_TYPE: