Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 1600243002: Revert of Use registerWeakMembers to clean up IntersectionObserver. (Closed)

Created:
4 years, 11 months ago by sof
Modified:
4 years, 11 months ago
Reviewers:
haraken, szager1, dcheng
CC:
chromium-reviews, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use registerWeakMembers to clean up IntersectionObserver. (patchset #1 id:1 of https://codereview.chromium.org/1591763003/ ) Reason for revert: Broke on some tests w/ Oilpan enabled, https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%20Leak/builds/16410 backing it out. (see also https://codereview.chromium.org/1596333002/ ) Original issue's description: > Use registerWeakMembers to clean up IntersectionObserver. > > Pre-oilpan, when the root disappears, it observers are cleaned up > in NodeIntersectionObserverData::dispose(). > > Post-oilpan, the cleanup will be done with registerWeakMembers. > > BUG=540528 > R=haraken@chromium.org,dcheng@chromium.org > > Committed: https://crrev.com/546573354e47ddd01f491c382701fa51500f85eb > Cr-Commit-Position: refs/heads/master@{#369948} TBR=dcheng@chromium.org,haraken@chromium.org,szager@chromium.org BUG=540528 NOTRY=true Committed: https://crrev.com/7beaecbcac87a75ced26b4415fb84fc2cf559307 Cr-Commit-Position: refs/heads/master@{#369970}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M third_party/WebKit/Source/core/dom/IntersectionObserver.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObserver.cpp View 7 chunks +22 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sof
Created Revert of Use registerWeakMembers to clean up IntersectionObserver.
4 years, 11 months ago (2016-01-17 21:39:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1600243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1600243002/1
4 years, 11 months ago (2016-01-17 21:39:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1600243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1600243002/1
4 years, 11 months ago (2016-01-17 21:46:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-17 21:50:53 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7beaecbcac87a75ced26b4415fb84fc2cf559307 Cr-Commit-Position: refs/heads/master@{#369970}
4 years, 11 months ago (2016-01-17 21:52:16 UTC) #10
haraken
4 years, 11 months ago (2016-01-18 03:20:48 UTC) #11
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698